Skip to content

connection: eliminate member remote_addr #17385

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from

Conversation

icing
Copy link
Contributor

@icing icing commented May 19, 2025

Used to be a pointer set (and cleared) by the socket connection filters to a struct in their contexts. Instead, add a filter query method to obtain the pointer when needed.

@icing icing added the tidy-up label May 19, 2025
@icing icing requested a review from bagder May 19, 2025 13:28
@icing icing added the feature-window A merge of this requires an open feature window label May 20, 2025
@icing icing force-pushed the conn-remote-addr-gone branch from 8d32717 to 5bb1852 Compare May 22, 2025 07:57
@icing icing marked this pull request as draft May 22, 2025 09:22
icing added 5 commits May 26, 2025 12:26
Used to be a pointer set (and cleared) by the socket
connection filters to a struct in their contexts. Instead,
add a filter query method to obtain the pointer when needed.
@icing icing force-pushed the conn-remote-addr-gone branch from 5bb1852 to 1cd9d5f Compare May 26, 2025 10:29
@curl curl deleted a comment from testclutch May 26, 2025
@icing icing marked this pull request as ready for review May 26, 2025 11:03
@bagder bagder closed this in 6338142 Jun 20, 2025
denandz pushed a commit to denandz/curl that referenced this pull request Jun 21, 2025
Used to be a pointer set (and cleared) by the socket connection filters
to a struct in their contexts. Instead, add a filter query method to
obtain the pointer when needed.

Closes curl#17385
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-window A merge of this requires an open feature window tidy-up
Development

Successfully merging this pull request may close these issues.

2 participants