bufq: change read/write signatures #17396
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change the `ssize_t Curl_bufq_*(..., CURLcode *err)` functions to use `CURLcode Curl_bufq_*(..., size_t *pn)` instead. In line with the send/recv adjustments in connection filters and elsewhere.
|
@cmeister2 How would we best merge this change? Disable fuzzing of bufq, merge, then adapt and re-enable? |
|
@icing probably the best way forward, yes. Happy to approve PRs on curl-fuzzer to do that. |
|
Once this is merged, I'll adapt the fuzzer_bufq for the change and re-enable it. @vszakats when you find time, would be nice. |
|
LGTM, and merged! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change the signature of
bufqfunctions fromssize_t Curl_bufq_*(..., CURLcode *err)toCURLcode Curl_bufq_*(..., size_t *pn)This allows us to write slightly less code and avoids the ssize_t/size_t conversions in many cases. Also, it gets the function in line with all the other send/recv signatures.
Added helper functions in
cfilters.hfor sending from/receving into a bufq.Fuzzer now fails to build due to these changes and its testing of the bufq API.