New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Add wolfSSL configurations to Visual Studio project files #174

Closed
wants to merge 9 commits into
base: master
from

Conversation

Projects
None yet
3 participants
@jay
Member

jay commented Mar 24, 2015

  • Add wolfSSL configurations to Visual Studio 2010+ project files:

DLL Debug - DLL wolfSSL
DLL Release - DLL wolfSSL
LIB Debug - LIB wolfSSL
LIB Release - LIB wolfSSL

  • Add wolfSSL Visual Studio build instructions.
@bagder

This comment has been minimized.

Show comment
Hide comment
@bagder

bagder Mar 24, 2015

Member

@captain-caveman2k can you take a look/merge ?

Member

bagder commented Mar 24, 2015

@captain-caveman2k can you take a look/merge ?

@bagder

This comment has been minimized.

Show comment
Hide comment
@bagder

bagder Mar 24, 2015

Member

Ah, and thanks a lot @jay for working on this (too) !

Member

bagder commented Mar 24, 2015

Ah, and thanks a lot @jay for working on this (too) !

build: Add wolfSSL configurations to Visual Studio project files
- Add wolfSSL configurations to Visual Studio 2010+ project files:

DLL Debug - DLL wolfSSL
DLL Release - DLL wolfSSL
LIB Debug - LIB wolfSSL
LIB Release - LIB wolfSSL

- Add wolfSSL Visual Studio build instructions.
@jay

This comment has been minimized.

Show comment
Hide comment
@jay

jay Apr 22, 2015

Member

I haven't gotten any feedback on this. I'm going to hold off for now and leave this open because besides that I think I'll add a build script for wolfssl similar to the build-openssl.bat so that it automates building wolfssl in a standard configuration compatible with libcurl for vc{10,11,12,etc}. Once I do that I'll have to change the directories in the project templates and then I'll poke someone for a review.

Member

jay commented Apr 22, 2015

I haven't gotten any feedback on this. I'm going to hold off for now and leave this open because besides that I think I'll add a build script for wolfssl similar to the build-openssl.bat so that it automates building wolfssl in a standard configuration compatible with libcurl for vc{10,11,12,etc}. Once I do that I'll have to change the directories in the project templates and then I'll poke someone for a review.

@jay jay added on-hold and removed next-feature-window labels Apr 25, 2015

@bagder bagder assigned jay and unassigned captain-caveman2k Apr 26, 2015

@jay

This comment has been minimized.

Show comment
Hide comment
@jay

jay Jun 30, 2015

Member

Ok I've added the build-wolfssl script to automatically build wolfSSL and I've also updated the wolfSSL README and project templates. I've tested it in Visual Studio 2010 but not 2012 or 2013.

@captain-caveman2k do you think you could take a look at this before the feature window closes? It's a whole lot of XML (2k-3k lines) so I'd like to get a review if possible. If not can you or @bagder let me know who I should ping about this? Thanks!

Member

jay commented Jun 30, 2015

Ok I've added the build-wolfssl script to automatically build wolfSSL and I've also updated the wolfSSL README and project templates. I've tested it in Visual Studio 2010 but not 2012 or 2013.

@captain-caveman2k do you think you could take a look at this before the feature window closes? It's a whole lot of XML (2k-3k lines) so I'd like to get a review if possible. If not can you or @bagder let me know who I should ping about this? Thanks!

@jay jay removed the on-hold label Jun 30, 2015

@jay

This comment has been minimized.

Show comment
Hide comment
@jay

jay Jul 15, 2015

Member

@bagder What do you recommend I do at this point? There's a lot of change here. I'd appreciate a second set of eyes and I'm not 100% on Steve's format (though a lot of the XML changes I made were generated by Visual Studio so they should be fine).

Member

jay commented Jul 15, 2015

@bagder What do you recommend I do at this point? There's a lot of change here. I'd appreciate a second set of eyes and I'm not 100% on Steve's format (though a lot of the XML changes I made were generated by Visual Studio so they should be fine).

@captain-caveman2k

This comment has been minimized.

Show comment
Hide comment
@captain-caveman2k

captain-caveman2k Jul 21, 2015

Member

Hi Guys,

Sorry for not being around over the last few months.

I spoke to Daniel a couple of weeks ago regarding my curl plans so hopefully you should start to see a little more of me now.

I'm just downloading these changes now and will be back with some comments shortly ;-)

Member

captain-caveman2k commented Jul 21, 2015

Hi Guys,

Sorry for not being around over the last few months.

I spoke to Daniel a couple of weeks ago regarding my curl plans so hopefully you should start to see a little more of me now.

I'm just downloading these changes now and will be back with some comments shortly ;-)

@captain-caveman2k

This comment has been minimized.

Show comment
Hide comment
@captain-caveman2k

captain-caveman2k Jul 29, 2015

Member

Hey @jay,

I started taking a look at your changes last week and then spent the weekend concentrating on the VC14 project files (after Microsoft's release of Visual Studio 2015 last week). As you will have noticed I have slowing been pushing those changes over the last few days - which I am now done with ;-)

As such I am now taking a look at these changes. Perhaps @bagder would be so kind to assign this PR to be again ;-)

Anyway, I have a bunch of questions that, if it is okay with you, will ping over to you in a private email?

Cheers

Steve

Member

captain-caveman2k commented Jul 29, 2015

Hey @jay,

I started taking a look at your changes last week and then spent the weekend concentrating on the VC14 project files (after Microsoft's release of Visual Studio 2015 last week). As you will have noticed I have slowing been pushing those changes over the last few days - which I am now done with ;-)

As such I am now taking a look at these changes. Perhaps @bagder would be so kind to assign this PR to be again ;-)

Anyway, I have a bunch of questions that, if it is okay with you, will ping over to you in a private email?

Cheers

Steve

@captain-caveman2k

This comment has been minimized.

Show comment
Hide comment
@captain-caveman2k

captain-caveman2k Jul 29, 2015

Member

Note: I have a copy of your repo, have rebased against master and now have these 6 changes in a local branch against badger/curl.

Member

captain-caveman2k commented Jul 29, 2015

Note: I have a copy of your repo, have rebased against master and now have these 6 changes in a local branch against badger/curl.

@jay jay assigned captain-caveman2k and unassigned jay Jul 30, 2015

@jay

This comment has been minimized.

Show comment
Hide comment
@jay

jay Jul 30, 2015

Member

Steve, you're welcome to e-mail me. Generally speaking though for the benefit of the project and in the spirit of open source I prefer to keep everything that's not sensitive in some form of public record. Why don't you e-mail me for now (you've piqued my curiosity) and we can package a summary for this thread if it should be public. I reassigned this PR to you.

Member

jay commented Jul 30, 2015

Steve, you're welcome to e-mail me. Generally speaking though for the benefit of the project and in the spirit of open source I prefer to keep everything that's not sensitive in some form of public record. Why don't you e-mail me for now (you've piqued my curiosity) and we can package a summary for this thread if it should be public. I reassigned this PR to you.

jay added a commit that referenced this pull request Aug 6, 2015

@captain-caveman2k

This comment has been minimized.

Show comment
Hide comment
@captain-caveman2k

captain-caveman2k Aug 6, 2015

Member

Hi Guys,

I just wanted to post a summary of my queries following my emails with Jay over the last week as I have now pushed a compressed set of changes:

  • Am I correct in thinking that the wolfSSL build script supports VC14 builds?
  • Are the property sheet and header file from the "curl\projects" folder required and are they not part of the wolfSSL source package?
  • Could the contents of the wolfSSL readme be added to the main README as some of the content seems relevant to our other build configurations?
  • Is it possible to support wolfSSL in versions of Visual Studio prior to 2010 (VC10)?

As mentioned above I have now pushed two changes, which are compacted versions of Jay's changes which evolved since the original commit in March:

  1. Addition of build-wolfssl.bat, header file and property sheet.

As build-wolfssl.bat is based on build-openssl.bat I have combined the later commit that fixes showing the syntax if the required arguments are missing as in my opinion the addition of build-wolfssl.bat should be based on the current build-openssl.bat ;-)

I updated Makefile.am so that build-wolfssl.bat is included in the release and daily snapshot archives. We will see overnight if I got that correct!!

  1. Updates to the Visual Studio project files

As I pushed the commit to add build-wolfssl.bat first I couldn't see the point in having two separate commits, the first to add the configurations and the second to change the paths following the addition of build-wolfssl.bat. I also combined the third commit of adding the CYASSL pre-processor directive to the libcurl project files.

As I added the Visual Studio 2015 (VC14) project files the other week I have also added support for the wolfSSL configurations in those files as well (under the same commit that is credited to Jay rather than separately as me).

Obviously I renamed the curlsrc solution and project files to curl and updated output filenames to reflect that change - as such that cause me some pain and had to rework the commits to work with those changes.

I am still working on the README file - as some of Jay's wolfSSL readme is appropriate to our other configurations as well - this will be done over the next few days.

@bagder Do we have a preference of having these README files in plain text or in Markdown format? I'm happy to work with either.

Member

captain-caveman2k commented Aug 6, 2015

Hi Guys,

I just wanted to post a summary of my queries following my emails with Jay over the last week as I have now pushed a compressed set of changes:

  • Am I correct in thinking that the wolfSSL build script supports VC14 builds?
  • Are the property sheet and header file from the "curl\projects" folder required and are they not part of the wolfSSL source package?
  • Could the contents of the wolfSSL readme be added to the main README as some of the content seems relevant to our other build configurations?
  • Is it possible to support wolfSSL in versions of Visual Studio prior to 2010 (VC10)?

As mentioned above I have now pushed two changes, which are compacted versions of Jay's changes which evolved since the original commit in March:

  1. Addition of build-wolfssl.bat, header file and property sheet.

As build-wolfssl.bat is based on build-openssl.bat I have combined the later commit that fixes showing the syntax if the required arguments are missing as in my opinion the addition of build-wolfssl.bat should be based on the current build-openssl.bat ;-)

I updated Makefile.am so that build-wolfssl.bat is included in the release and daily snapshot archives. We will see overnight if I got that correct!!

  1. Updates to the Visual Studio project files

As I pushed the commit to add build-wolfssl.bat first I couldn't see the point in having two separate commits, the first to add the configurations and the second to change the paths following the addition of build-wolfssl.bat. I also combined the third commit of adding the CYASSL pre-processor directive to the libcurl project files.

As I added the Visual Studio 2015 (VC14) project files the other week I have also added support for the wolfSSL configurations in those files as well (under the same commit that is credited to Jay rather than separately as me).

Obviously I renamed the curlsrc solution and project files to curl and updated output filenames to reflect that change - as such that cause me some pain and had to rework the commits to work with those changes.

I am still working on the README file - as some of Jay's wolfSSL readme is appropriate to our other configurations as well - this will be done over the next few days.

@bagder Do we have a preference of having these README files in plain text or in Markdown format? I'm happy to work with either.

jgsogo added a commit to jgsogo/curl that referenced this pull request Oct 19, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment