Test client authentication (mtls) with --insecure, clientAuth EKU only #17493
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If there were two tests using the "https-mtls" server there was a perl unbound variable error, since certfile wan't set. Additionally, once the responsiveserver function was actually called, it failed finding a responsiveness function. For now I made it use the `verifypid` function, since the curl execution in `verifyhttp` doesn't know about client certificates.
The google chrome root program will stop allowing roots that have both clientAuth and ServerAuth [1]. In one of the mtls tests, use a certificate with only the clientAuth EKU. [1] https://googlechrome.github.io/chromerootprogram/#322-pki-hierarchies-included-in-the-chrome-root-store
yedayak
changed the title
This comment was marked as outdated.
This comment was marked as outdated.
bagder
approved these changes
May 31, 2025
bagder
pushed a commit
that referenced
this pull request
May 31, 2025
bagder
pushed a commit
that referenced
this pull request
May 31, 2025
The google chrome root program will stop allowing roots that have both clientAuth and ServerAuth [1]. In one of the mtls tests, use a certificate with only the clientAuth EKU. [1] https://googlechrome.github.io/chromerootprogram/#322-pki-hierarchies-included-in-the-chrome-root-store Closes #17493
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additionally, once the responsiveserver function was actually called, it failed finding a responsiveness function. For now I made it use the
verifypidfunction, since the curl execution inverifyhttpdoesn't know about client certificates.[1] https://googlechrome.github.io/chromerootprogram/#322-pki-hierarchies-included-in-the-chrome-root-store