build: assume sys/socket.h, sys/time.h on non-Windows (as in curl/curl.h)
#17522
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
denandz
pushed a commit
to denandz/curl
that referenced
this pull request
Jun 21, 2025
…l/curl.h`) Public `curl/curl.h` includes these headers for non-Windows platforms without further conditions. This makes it safe to assume these headers do exist, allowing to save two feature checks for non-Windows targets. `sys/time.h` is also assumed on Windows with mingw-w64, for declaring `gettimeofday()`. Closes curl#17522
denandz
pushed a commit
to denandz/curl
that referenced
this pull request
Jun 21, 2025
Both are available with well-known conditions, under non-Windows, and `curl/curl.h` already uses them. `sys/time.h` is also necessary for mingw-w64 for `gettimeofday()`. Follow-up to 56d5982 curl#17522 Closes curl#17581
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Public
curl/curl.hincludes these headers for non-Windows platformswithout further conditions. This makes it safe to assume these headers
do exist, allowing to save two feature checks for non-Windows targets.
sys/time.his also assumed on Windows with mingw-w64, for declaringgettimeofday().HAVE_SYS_SOCKET_HandHAVE_SYS_TIME_Hfrom C code?