Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

travis: verify "make install" as well #1753

Closed
wants to merge 3 commits into from

Conversation

Projects
None yet
3 participants
@bagder
Copy link
Member

commented Aug 9, 2017

No description provided.

@coveralls

This comment has been minimized.

Copy link

commented Aug 10, 2017

Coverage Status

Coverage increased (+0.02%) to 75.316% when pulling 5ef2f20 on bagder/travis-test-install into 7e949de on master.

exit
fi

diff -u <(find include/ -name "*.h" -printf "%f\n" | sort) <(find $PREFIX/include/ -name "*.h" -printf "%f\n" | sort)

This comment has been minimized.

Copy link
@jay

jay Aug 10, 2017

Member

Isn't there supposed to be a check after this

This comment has been minimized.

Copy link
@bagder

bagder Aug 10, 2017

Author Member

it doesn't technically need one, but you're right. It will be nicer and make it easier to expand the script later! Will fix.

This comment has been minimized.

Copy link
@jay

jay Aug 10, 2017

Member

Is this script supposed to return failure if it fails? AFAIK you'd have to rc=$? then compare that and exit $rc, because otherwise the if test is going to overwrite $? 0 (edit: echo command also does it of course basically any command) so exit by itself is going to exit 0

This comment has been minimized.

Copy link
@bagder

bagder Aug 10, 2017

Author Member

I'll fix!

bagder added some commits Aug 10, 2017

installcheck.sh: check the return code from the second diff too
... and display a message if it triggers.
@coveralls

This comment has been minimized.

Copy link

commented Aug 10, 2017

Coverage Status

Coverage decreased (-0.007%) to 75.291% when pulling 6d38185 on bagder/travis-test-install into 7e949de on master.

@bagder bagder closed this in 478596b Aug 10, 2017

@bagder bagder deleted the bagder/travis-test-install branch Aug 10, 2017

@lock lock bot locked as resolved and limited conversation to collaborators Jan 18, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.