Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

travis: verify "make install" as well

Closed
wants to merge 3 commits into from

Conversation

bagder
Copy link
Member

@bagder bagder commented Aug 9, 2017

No description provided.

@coveralls
Copy link

coveralls commented Aug 10, 2017

Coverage Status

Coverage increased (+0.02%) to 75.316% when pulling 5ef2f20 on bagder/travis-test-install into 7e949de on master.

exit
fi

diff -u <(find include/ -name "*.h" -printf "%f\n" | sort) <(find $PREFIX/include/ -name "*.h" -printf "%f\n" | sort)
Copy link
Member

@jay jay Aug 10, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't there supposed to be a check after this

Copy link
Member Author

@bagder bagder Aug 10, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it doesn't technically need one, but you're right. It will be nicer and make it easier to expand the script later! Will fix.

Copy link
Member

@jay jay Aug 10, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this script supposed to return failure if it fails? AFAIK you'd have to rc=$? then compare that and exit $rc, because otherwise the if test is going to overwrite $? 0 (edit: echo command also does it of course basically any command) so exit by itself is going to exit 0

Copy link
Member Author

@bagder bagder Aug 10, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll fix!

@coveralls
Copy link

coveralls commented Aug 10, 2017

Coverage Status

Coverage decreased (-0.007%) to 75.291% when pulling 6d38185 on bagder/travis-test-install into 7e949de on master.

@bagder bagder closed this in 478596b Aug 10, 2017
@bagder bagder deleted the bagder/travis-test-install branch Aug 10, 2017
@lock lock bot locked as resolved and limited conversation to collaborators Jan 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants