travis: verify "make install" as well #1753

Closed
wants to merge 3 commits into
from

Conversation

Projects
None yet
3 participants
@bagder
Member

bagder commented Aug 9, 2017

No description provided.

@coveralls

This comment has been minimized.

Show comment Hide comment
@coveralls

coveralls Aug 10, 2017

Coverage Status

Coverage increased (+0.02%) to 75.316% when pulling 5ef2f20 on bagder/travis-test-install into 7e949de on master.

Coverage Status

Coverage increased (+0.02%) to 75.316% when pulling 5ef2f20 on bagder/travis-test-install into 7e949de on master.

scripts/installcheck.sh
+ exit
+fi
+
+diff -u <(find include/ -name "*.h" -printf "%f\n" | sort) <(find $PREFIX/include/ -name "*.h" -printf "%f\n" | sort)

This comment has been minimized.

Show comment Hide comment
@jay

jay Aug 10, 2017

Member

Isn't there supposed to be a check after this

@jay

jay Aug 10, 2017

Member

Isn't there supposed to be a check after this

This comment has been minimized.

Show comment Hide comment
@bagder

bagder Aug 10, 2017

Member

it doesn't technically need one, but you're right. It will be nicer and make it easier to expand the script later! Will fix.

@bagder

bagder Aug 10, 2017

Member

it doesn't technically need one, but you're right. It will be nicer and make it easier to expand the script later! Will fix.

This comment has been minimized.

Show comment Hide comment
@jay

jay Aug 10, 2017

Member

Is this script supposed to return failure if it fails? AFAIK you'd have to rc=$? then compare that and exit $rc, because otherwise the if test is going to overwrite $? 0 (edit: echo command also does it of course basically any command) so exit by itself is going to exit 0

@jay

jay Aug 10, 2017

Member

Is this script supposed to return failure if it fails? AFAIK you'd have to rc=$? then compare that and exit $rc, because otherwise the if test is going to overwrite $? 0 (edit: echo command also does it of course basically any command) so exit by itself is going to exit 0

This comment has been minimized.

Show comment Hide comment
@bagder

bagder Aug 10, 2017

Member

I'll fix!

@bagder

bagder Aug 10, 2017

Member

I'll fix!

bagder added some commits Aug 10, 2017

installcheck.sh: check the return code from the second diff too
... and display a message if it triggers.
@coveralls

This comment has been minimized.

Show comment Hide comment
@coveralls

coveralls Aug 10, 2017

Coverage Status

Coverage decreased (-0.007%) to 75.291% when pulling 6d38185 on bagder/travis-test-install into 7e949de on master.

Coverage Status

Coverage decreased (-0.007%) to 75.291% when pulling 6d38185 on bagder/travis-test-install into 7e949de on master.

@bagder bagder closed this in 478596b Aug 10, 2017

@bagder bagder deleted the bagder/travis-test-install branch Aug 10, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment