Closed
Conversation
cfilter/conn: change send/recv function signatures. Unify the calling/return conventions in our send/receive handling. Curl_conn_recv(), adjust pnread type Parameter `pnread` was a `ssizet_t *`, but `size_t *` is better since the function returns any error in its `CURLcode` return value.
bagder
approved these changes
Jun 11, 2025
denandz
pushed a commit
to denandz/curl
that referenced
this pull request
Jun 21, 2025
cfilter/conn: change send/recv function signatures. Unify the calling/return conventions in our send/receive handling. Curl_conn_recv(), adjust pnread type Parameter `pnread` was a `ssize_t *`, but `size_t *` is better since the function returns any error in its `CURLcode` return value. Closes curl#17546
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unify the calling/return conventions in our send/receive handling. This PR does not change all such functions in libcurl, but the major ones. Others to be tackled after this PR.
cfilters: change callback function signatures:
Change
Curl_sendandCurl_recvprototypes:The new form is peferrable:
size_t *parameter is meaningless. This simplifies handling of errors after thesize_t *has been assigned.ssize_treturn value always needed conversion tosize_twhen not negative. This is now unnecessary.-1which left other negative returns in undefined state.Curl_conn_recv(): adjust pnread type:
Parameter
pnreadwas assizet_t *, butsize_t *is better since the function returns any error in itsCURLcodereturn value.