Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unify the calling/return conventions in our send/receive handling. This PR does not change all such functions in libcurl, but the major ones. Others to be tackled after this PR.
cfilters: change callback function signatures:
Change
Curl_send
andCurl_recv
prototypes:The new form is peferrable:
size_t *
parameter is meaningless. This simplifies handling of errors after thesize_t *
has been assigned.ssize_t
return value always needed conversion tosize_t
when not negative. This is now unnecessary.-1
which left other negative returns in undefined state.Curl_conn_recv(): adjust pnread type:
Parameter
pnread
was assizet_t *
, butsize_t *
is better since the function returns any error in itsCURLcode
return value.