Closed
Conversation
icing
force-pushed
the
conn-meta-auth
branch
2 times, most recently
from
96f31bd to
040c4b6
Compare
Remove structs for negotiate, krb5, ntlm and gsasl from connectdata and store them as connection meta data with auto cleanup. De-complexify sasl mech selection by moving code into static functions.
bagder
approved these changes
Jun 10, 2025
denandz
pushed a commit
to denandz/curl
that referenced
this pull request
Jun 21, 2025
Remove structs for negotiate, krb5, ntlm and gsasl from connectdata and store them as connection meta data with auto cleanup. De-complexify sasl mech selection by moving code into static functions. Closes curl#17557
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move auth structs to conn meta data.
Remove structs for negotiate, krb5, ntlm and gsasl from connectdata and store them as connection meta data with auto cleanup.
De-complexify sasl mech selection by moving code into static functions.