strtoofft: overhaul to address integer overflow risks globally #1758

Closed
wants to merge 2 commits into
from

Conversation

Projects
None yet
3 participants
@bagder
Member

bagder commented Aug 10, 2017

... make sure we bail out on overflows.

Reported-by: Brian Carpenter

bagder added some commits Aug 12, 2017

strtoofft: reduce integer overflow risks globally
... make sure we bail out on overflows.

Reported-by: Brian Carpenter

@bagder bagder deleted a comment from coveralls Aug 12, 2017

@bagder bagder deleted a comment from coveralls Aug 12, 2017

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Aug 13, 2017

Coverage Status

Coverage increased (+0.02%) to 75.067% when pulling ffa73dd on bagder/number-parsing-overhaul into 6bde13a on master.

Coverage Status

Coverage increased (+0.02%) to 75.067% when pulling ffa73dd on bagder/number-parsing-overhaul into 6bde13a on master.

@bagder bagder closed this in ff50fe0 Aug 14, 2017

@bagder bagder deleted the bagder/number-parsing-overhaul branch Aug 14, 2017

@dfandrich

This comment has been minimized.

Show comment
Hide comment
@dfandrich

dfandrich Aug 25, 2017

Collaborator

This broke non-MSVC builds that need HAVE_STRTOLL, e.g. https://curl.haxx.se/dev/log.cgi?id=20170825014632-29789#prob8

Collaborator

dfandrich commented Aug 25, 2017

This broke non-MSVC builds that need HAVE_STRTOLL, e.g. https://curl.haxx.se/dev/log.cgi?id=20170825014632-29789#prob8

bagder added a commit that referenced this pull request Aug 25, 2017

@bagder

This comment has been minimized.

Show comment
Hide comment
@bagder

bagder Aug 25, 2017

Member

@dfandrich can you perhaps try out #1829 manually and see if it is good enough for this?

Member

bagder commented Aug 25, 2017

@dfandrich can you perhaps try out #1829 manually and see if it is good enough for this?

bagder added a commit that referenced this pull request Aug 27, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment