Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

strtoofft: overhaul to address integer overflow risks globally #1758

Closed
wants to merge 2 commits into from

Conversation

@bagder
Copy link
Member

commented Aug 10, 2017

... make sure we bail out on overflows.

Reported-by: Brian Carpenter

@bagder bagder force-pushed the bagder/number-parsing-overhaul branch from c023769 to b3f3381 Aug 12, 2017
bagder added 2 commits Aug 12, 2017
... make sure we bail out on overflows.

Reported-by: Brian Carpenter
@bagder bagder force-pushed the bagder/number-parsing-overhaul branch from b3f3381 to ffa73dd Aug 12, 2017
@curl curl deleted a comment from coveralls Aug 12, 2017
@curl curl deleted a comment from coveralls Aug 12, 2017
@coveralls

This comment has been minimized.

Copy link

commented Aug 13, 2017

Coverage Status

Coverage increased (+0.02%) to 75.067% when pulling ffa73dd on bagder/number-parsing-overhaul into 6bde13a on master.

@bagder bagder closed this in ff50fe0 Aug 14, 2017
@bagder bagder deleted the bagder/number-parsing-overhaul branch Aug 14, 2017
@dfandrich

This comment has been minimized.

Copy link
Collaborator

commented Aug 25, 2017

This broke non-MSVC builds that need HAVE_STRTOLL, e.g. https://curl.haxx.se/dev/log.cgi?id=20170825014632-29789#prob8

bagder added a commit that referenced this pull request Aug 25, 2017
Reported-by: Dan Fandrich
Bug: #1758 (comment)
@bagder

This comment has been minimized.

Copy link
Member Author

commented Aug 25, 2017

@dfandrich can you perhaps try out #1829 manually and see if it is good enough for this?

bagder added a commit that referenced this pull request Aug 27, 2017
Closes #1829

Reported-by: Dan Fandrich
Bug: #1758 (comment)
@lock lock bot locked as resolved and limited conversation to collaborators Jan 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
3 participants
You can’t perform that action at this time.