Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

strtoofft: overhaul to address integer overflow risks globally #1758

wants to merge 2 commits into from


Copy link

@bagder bagder commented Aug 10, 2017

... make sure we bail out on overflows.

Reported-by: Brian Carpenter

@bagder bagder force-pushed the bagder/number-parsing-overhaul branch from c023769 to b3f3381 Compare August 12, 2017 15:54
@bagder bagder force-pushed the bagder/number-parsing-overhaul branch from b3f3381 to ffa73dd Compare August 12, 2017 23:05
@curl curl deleted a comment from coveralls Aug 12, 2017
@curl curl deleted a comment from coveralls Aug 12, 2017
Copy link

Coverage Status

Coverage increased (+0.02%) to 75.067% when pulling ffa73dd on bagder/number-parsing-overhaul into 6bde13a on master.

@bagder bagder closed this in ff50fe0 Aug 14, 2017
@bagder bagder deleted the bagder/number-parsing-overhaul branch August 14, 2017 21:34
Copy link

This broke non-MSVC builds that need HAVE_STRTOLL, e.g.

Copy link
Member Author

bagder commented Aug 25, 2017

@dfandrich can you perhaps try out #1829 manually and see if it is good enough for this?

bagder added a commit that referenced this pull request Aug 27, 2017
@lock lock bot locked as resolved and limited conversation to collaborators Jan 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

3 participants