cmake: drop never propagated C macros#17580
Closed
vszakats wants to merge 3 commits intocurl:masterfrom
Closed
Conversation
2 tasks
denandz
pushed a commit
to denandz/curl
that referenced
this pull request
Jun 21, 2025
Delete macros from `curl_config.h.cmake` that were never set by the CMake script: `_LARGE_FILES`, `_THREAD_SAFE`, `const`, `size_t`. Also: - lib/config-riscos.h: drop `#undef _LARGE_FILES`. This is an IBM-specific macro, no need to unset it on other platforms. Cherry-picked from curl#17576 Closes curl#17580
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Delete macros from
curl_config.h.cmakethat were never set bythe CMake script:
_LARGE_FILES,_THREAD_SAFE,const,size_t.Also:
#undef _LARGE_FILES. This is anIBM-specific macro, no need to unset it on other platforms.
Cherry-picked from #17576