http_ntlm: remove unreachable code #17587
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since the code now checks for NULL and returns before this point, 'ntlm' cannot be NULL at this point in the code. Pointed out by Coverity. Follow-up to 5586520
|
Analysis of PR #17587 at eb49937d: Test 807 failed, which has NOT been flaky recently, so there could be a real issue in this PR. Note that this test has failed in 6 different CI jobs (the link just goes to one of them). Generated by Testclutch |
denandz
pushed a commit
to denandz/curl
that referenced
this pull request
Jun 21, 2025
Since the code now checks for NULL and returns before this point, 'ntlm' cannot be NULL at this point in the code. Pointed out by Coverity. Follow-up to 5586520 Closes curl#17587
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the code now checks for NULL and returns before this point, 'ntlm' cannot be NULL at this point in the code. Pointed out by Coverity.
Follow-up to 5586520