Skip to content

vtls: change send/recv signatures of tls backends#17593

Closed
icing wants to merge 5 commits intocurl:masterfrom
icing:vtls-send-recv-sigs
Closed

vtls: change send/recv signatures of tls backends#17593
icing wants to merge 5 commits intocurl:masterfrom
icing:vtls-send-recv-sigs

Conversation

@icing
Copy link
Copy Markdown
Contributor

@icing icing commented Jun 11, 2025

Similar to connection filter changes, return a CURLcode and the read/written amount as size_t *.

@github-actions github-actions bot added the TLS label Jun 11, 2025
@testclutch
Copy link
Copy Markdown

Analysis of PR #17593 at 65b84e77:

Test 410 failed, which has NOT been flaky recently, so there could be a real issue in this PR. Note that this test has failed in 6 different CI jobs (the link just goes to one of them).

Generated by Testclutch

@jay
Copy link
Copy Markdown
Member

jay commented Jun 15, 2025

please check if the valgrind ci failure is related. the ancestor you branched from does not have this failure.

=== Start of file valgrind410
 ==119773== Conditional jump or move depends on uninitialised value(s)
 ==119773==    at 0x48E9234: out_number (mprintf.c:793)
 ==119773==    by 0x48E9CAE: formatf (mprintf.c:1041)
 ==119773==    by 0x48E9F96: curl_mvsnprintf (mprintf.c:1113)
 ==119773==    by 0x489EFB9: trc_infof (curl_trc.c:230)
 ==119773==    by 0x489F32B: Curl_trc_cf_infof (curl_trc.c:253)
 ==119773==    by 0x493F03F: mbed_send (mbedtls.c:1249)
 ==119773==    by 0x4944068: ssl_cf_send (vtls.c:1489)
 ==119773==    by 0x4889B10: Curl_cf_def_send (cfilters.c:105)
 ==119773==    by 0x4889B10: Curl_cf_def_send (cfilters.c:105)
 ==119773==    by 0x488A45C: Curl_cf_send (cfilters.c:269)
 ==119773==    by 0x488C5B9: Curl_conn_send (cfilters.c:941)
 ==119773==    by 0x4923116: Curl_xfer_send (transfer.c:941)
 ==119773==    by 0x4902580: xfer_send (request.c:215)
 ==119773==    by 0x49026F2: req_send_buffer_flush (request.c:242)
 ==119773==    by 0x4902B11: req_flush (request.c:296)
 ==119773==    by 0x490327A: Curl_req_send_more (request.c:446)

@icing icing force-pushed the vtls-send-recv-sigs branch from 65b84e7 to 258ba2d Compare June 16, 2025 08:10
@icing
Copy link
Copy Markdown
Contributor Author

icing commented Jun 16, 2025

please check if the valgrind ci failure is related. the ancestor you branched from does not have this failure.

Thanks, fixed via cfa807a

@icing icing force-pushed the vtls-send-recv-sigs branch from ff15032 to 4ccdcb5 Compare June 16, 2025 11:11
@icing icing requested review from bagder and jay June 20, 2025 07:16
Copy link
Copy Markdown
Member

@jay jay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm but I'll leave it to @bagder whether to land it for rc-8_15_0-1 for today

Copy link
Copy Markdown
Member

@bagder bagder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@bagder bagder closed this in b7c676d Jun 21, 2025
denandz pushed a commit to denandz/curl that referenced this pull request Jun 21, 2025
Similar to connection filter changes, return a CURLcode and the
read/written amount as size_t *.

Closes curl#17593
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

4 participants