-
-
Notifications
You must be signed in to change notification settings - Fork 6.8k
vtls: change send/recv signatures of tls backends #17593
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Analysis of PR #17593 at 65b84e77: Test 410 failed, which has NOT been flaky recently, so there could be a real issue in this PR. Note that this test has failed in 6 different CI jobs (the link just goes to one of them). Generated by Testclutch |
please check if the valgrind ci failure is related. the ancestor you branched from does not have this failure.
|
65b84e7
to
258ba2d
Compare
Thanks, fixed via cfa807a |
Similar to connection filter changes, return a CURLcode and the read/written amount as size_t *.
ff15032
to
4ccdcb5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm but I'll leave it to @bagder whether to land it for rc-8_15_0-1 for today
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Similar to connection filter changes, return a CURLcode and the read/written amount as size_t *. Closes curl#17593
Similar to connection filter changes, return a CURLcode and the read/written amount as size_t *.