Closed
Conversation
cpu
commented
Jun 11, 2025
bagder
reviewed
Jun 11, 2025
Member
They're not externally visible so they can be dropped as well. |
Member
|
I can take care of the command line tool separately. |
cpu
force-pushed
the
cpu-tidy-false-start
branch
from
a58e86f to
e05ba2c
Compare
cpu
changed the title
Contributor
Author
|
I think there are two pieces of docs worth looking at with this change: Happy to add adjustments to those in this branch but I'm not sure if both should be deleted outright, or instead updated to describe the lack of support? |
Contributor
Author
Oh, sorry. I missed this comment and I think #17597 and this branch are overlapping a bit. |
bagder
reviewed
Jun 11, 2025
Member
cpu
force-pushed
the
cpu-tidy-false-start
branch
from
e05ba2c to
b6062f0
Compare
The secure transport vTLS backend was the only Curl_ssl struct instance that populated the false_start field. Since its removed, we can now remove that field entirely. This was a protocol feature specific to TLS 1.2 that has been replaced by the more widely adopted TLS 1.3 early data mechanisms.
cpu
force-pushed
the
cpu-tidy-false-start
branch
from
b6062f0 to
e89ab93
Compare
bagder
approved these changes
Jun 12, 2025
Member
|
Thanks! |
vszakats
pushed a commit
that referenced
this pull request
Jun 14, 2025
Reported-by: 4lan.m Ref: 1e2e808#r159957160 Follow-up to 1e2e808 #17595 Closes #17615
vszakats
added a commit
that referenced
this pull request
Jun 14, 2025
denandz
pushed a commit
to denandz/curl
that referenced
this pull request
Jun 21, 2025
The secure transport vTLS backend was the only Curl_ssl struct instance that populated the false_start field. Since its removed, we can now remove that field entirely. This was a protocol feature specific to TLS 1.2 that has been replaced by the more widely adopted TLS 1.3 early data mechanisms. --false-start is now deprecated Closes curl#17595
denandz
pushed a commit
to denandz/curl
that referenced
this pull request
Jun 21, 2025
Reported-by: 4lan.m Ref: curl@1e2e808#r159957160 Follow-up to 1e2e808 curl#17595 Closes curl#17615
denandz
pushed a commit
to denandz/curl
that referenced
this pull request
Jun 21, 2025
`CURLOPT_SSL_FALSESTART` / `--false-start`, Secure Transport, BearSSL, GSKit, MesaLink, NSS. Follow-up to 1e2e808 curl#17595 Follow-up to 08a3e8e curl#16677 Closes curl#17605
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The secure transport vTLS backend was the only
Curl_sslstruct instance that populated thefalse_startfield. Since it was removed in #16677, we can now remove that field entirely. This was a protocol feature specific to TLS 1.2 that has been replaced by the more widely adopted TLS 1.3 early data mechanisms. For this reason it seems unlikely anyone would add support to existing backends that lack it today.