tests: bundle http clients, de-dupe, enable for MSVC #17627
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vszakats
changed the title
vszakats
changed the title
2 tasks
vszakats
force-pushed
the
clients-bundle
branch
2 times, most recently
from
47a49a3 to
f4a518e
Compare
we need to include unistd.h for usleep, which is also pulling getopt
to align with libtests, servers, units, tunits.
vszakats
added a commit
that referenced
this pull request
Jun 16, 2025
Sync build properties with libtests. This allows accessing macros from `curl_config.h`, for feature flags. Smoothens out platform bumps, allowing to drop local replicas from client sources. It enables using Windows wrappers, e.g. for `fopen()`. Also fix client sources to use `curl_mfprintf()` where curl format strings are used. (To avoid build failure with older mingw-w64, e.g. 6.4.0 in CI.) Follow-up to 739c09c #17627 Closes #17642
denandz
pushed a commit
to denandz/curl
that referenced
this pull request
Jun 21, 2025
To make building the http client tests faster, with no duplication, by using the build method that other test binaries already use. The difference compared to other tests is that these don't use internal libcurl headers or code. With the exception of `curl_config.h`, for a feature macro. Before this patch, these tests were built like examples. Also: - de-duplicate code and give unique names to colliding symbols. - add local getopt implementation and enable all code for MSVC. Adapted for curl via Public Domain source: https://github.com/skeeto/getopt/blob/4e618ef782dc80b2cf0307ea74b68e6a62b025de/getopt.h Credits-to: Christopher Wellons Thanks! Closes curl#17627
denandz
pushed a commit
to denandz/curl
that referenced
this pull request
Jun 21, 2025
Sync build properties with libtests. This allows accessing macros from `curl_config.h`, for feature flags. Smoothens out platform bumps, allowing to drop local replicas from client sources. It enables using Windows wrappers, e.g. for `fopen()`. Also fix client sources to use `curl_mfprintf()` where curl format strings are used. (To avoid build failure with older mingw-w64, e.g. 6.4.0 in CI.) Follow-up to 739c09c curl#17627 Closes curl#17642
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To make building the http client tests faster, with no duplication, by
using the build method that other test binaries already use.
The difference compared to other tests is that these don't use internal
libcurl headers or code. With the exception of
curl_config.h, fora feature macro.
Before this patch, these tests were built like examples.
Also:
Adapted for curl via Public Domain source:
https://github.com/skeeto/getopt/blob/4e618ef782dc80b2cf0307ea74b68e6a62b025de/getopt.h
Credits-to: Christopher Wellons
Thanks!
AppVeyor CI:
before: https://ci.appveyor.com/project/curlorg/curl/builds/52239747
after: https://ci.appveyor.com/project/curlorg/curl/builds/52239856