cmake: Allow user to override CMAKE_DEBUG_POSTFIX#1763
Closed
webmaster128 wants to merge 1 commit intocurl:masterfrom
Closed
cmake: Allow user to override CMAKE_DEBUG_POSTFIX#1763webmaster128 wants to merge 1 commit intocurl:masterfrom
webmaster128 wants to merge 1 commit intocurl:masterfrom
Conversation
|
@webmaster128, thanks for your PR! By analyzing the history of the files in this pull request, we identified @snikulov, @billhoffman and @Sukender to be potential reviewers. |
bagder
approved these changes
Aug 11, 2017
Member
bagder
left a comment
There was a problem hiding this comment.
Seems totally reasonable to me!
Member
|
Thanks! |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #1649 the cache variable CMAKE_DEBUG_POSTFIX was set to "-d" by FORCE, giving the user no chance to override it to the desired value. This change keeps "-d" as default but allows users to change the value.
Current master
This PR
cc @paulharris