Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmake: Allow user to override CMAKE_DEBUG_POSTFIX #1763

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
4 participants
@webmaster128
Copy link
Contributor

commented Aug 11, 2017

In #1649 the cache variable CMAKE_DEBUG_POSTFIX was set to "-d" by FORCE, giving the user no chance to override it to the desired value. This change keeps "-d" as default but allows users to change the value.

Current master

$ mkdir build && cd build
$ cmake -DCMAKE_BUILD_TYPE=Debug ..
$ DESTDIR=installation make install

-- Installing: installation/usr/local/lib/libcurl-d.so

$ mkdir build && cd build
$ cmake -DCMAKE_BUILD_TYPE=Debug -DCMAKE_DEBUG_POSTFIX=_bar ..
$ DESTDIR=installation make install

-- Installing: installation/usr/local/lib/libcurl-d.so

This PR

$ mkdir build && cd build
$ cmake -DCMAKE_BUILD_TYPE=Debug ..
$ DESTDIR=installation make install

-- Installing: installation/usr/local/lib/libcurl-d.so

$ mkdir build && cd build
$ cmake -DCMAKE_BUILD_TYPE=Debug -DCMAKE_DEBUG_POSTFIX=_bar ..
$ DESTDIR=installation make install

-- Installing: installation/usr/local/lib/libcurl_bar.so

cc @paulharris

@mention-bot

This comment has been minimized.

Copy link

commented Aug 11, 2017

@webmaster128, thanks for your PR! By analyzing the history of the files in this pull request, we identified @snikulov, @billhoffman and @Sukender to be potential reviewers.

@coveralls

This comment has been minimized.

Copy link

commented Aug 11, 2017

Coverage Status

Coverage increased (+0.02%) to 75.099% when pulling 0b2931a on webmaster128:custom_suffix into 77cd4e7 on curl:master.

@bagder bagder added the cmake label Aug 11, 2017

@bagder

bagder approved these changes Aug 11, 2017

Copy link
Member

left a comment

Seems totally reasonable to me!

@bagder bagder closed this in 7f9bf5c Aug 12, 2017

@bagder

This comment has been minimized.

Copy link
Member

commented Aug 12, 2017

Thanks!

@lock lock bot locked as resolved and limited conversation to collaborators Jan 18, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.