Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upcmake: Allow user to override CMAKE_DEBUG_POSTFIX #1763
Conversation
This comment has been minimized.
This comment has been minimized.
mention-bot
commented
Aug 11, 2017
@webmaster128, thanks for your PR! By analyzing the history of the files in this pull request, we identified @snikulov, @billhoffman and @Sukender to be potential reviewers. |
This comment has been minimized.
This comment has been minimized.
coveralls
commented
Aug 11, 2017
bagder
added
the
cmake
label
Aug 11, 2017
bagder
approved these changes
Aug 11, 2017
Seems totally reasonable to me! |
bagder
closed this
in
7f9bf5c
Aug 12, 2017
This comment has been minimized.
This comment has been minimized.
Thanks! |
lock
bot
locked as resolved and limited conversation to collaborators
Jan 18, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
webmaster128 commentedAug 11, 2017
In #1649 the cache variable CMAKE_DEBUG_POSTFIX was set to "-d" by FORCE, giving the user no chance to override it to the desired value. This change keeps "-d" as default but allows users to change the value.
Current master
This PR
cc @paulharris