Skip to content

build: tidy up header paths, use srcdir where possible#17630

Closed
vszakats wants to merge 8 commits intocurl:masterfrom
vszakats:b-inc-dir-use-self
Closed

build: tidy up header paths, use srcdir where possible#17630
vszakats wants to merge 8 commits intocurl:masterfrom
vszakats:b-inc-dir-use-self

Conversation

@vszakats
Copy link
Member

@vszakats vszakats commented Jun 15, 2025

To improve readability.

Also add more comments on why each is necessary.

@vszakats vszakats marked this pull request as draft June 15, 2025 22:01
@vszakats vszakats marked this pull request as ready for review June 16, 2025 02:02
@vszakats vszakats force-pushed the b-inc-dir-use-self branch 2 times, most recently from 687f3a3 to 98a0876 Compare June 16, 2025 12:33
@vszakats
Copy link
Member Author

vszakats commented Jun 16, 2025

This message in lib/Makefile.am scared me off first:

# Specify our include paths here, and do it relative to $(top_srcdir) and
# $(top_builddir), to ensure that these paths which belong to the library
# being currently built and tested are searched before the library which
# might possibly already be installed in the system.

via 1e7125a

But testing shows that $(srcdir) and $(top_srcdir)/lib end up being the same in the verbose build log (both relative).
Same is true for CMake for ${CMAKE_CURRENT_SOURCE_DIR} vs. ${PROJECT_SOURCE_DIR}/tests/libtest (both absolute).

@vszakats vszakats force-pushed the b-inc-dir-use-self branch from b435025 to 1ba99f7 Compare June 19, 2025 11:11
@vszakats vszakats force-pushed the b-inc-dir-use-self branch from 1ba99f7 to 2fb89a6 Compare June 19, 2025 11:13
@vszakats vszakats closed this in 8e47c8a Jun 19, 2025
@vszakats vszakats deleted the b-inc-dir-use-self branch June 19, 2025 11:28
denandz pushed a commit to denandz/curl that referenced this pull request Jun 21, 2025
To improve readability.

Also add more comments on why each is necessary.

Closes curl#17630
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

1 participant

Comments