lib: make curlx_wait_ms() and use it
#17641
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vszakats
changed the title
curlx_wait_ms(), use it
vszakats
force-pushed
the
s-tidy
branch
3 times, most recently
from
0821651 to
3fa41fd
Compare
vszakats
changed the title
curlx_wait_ms(), use itcurlx_wait_ms() and use it
vszakats
force-pushed
the
s-tidy
branch
2 times, most recently
from
a7afb38 to
01131b0
Compare
According to local tests, current autotools doesn't need the headers listed there. It'll either auto-detect them with dependency tracking enabled (default), or ignore them with this option disabled, even if the headers are listed. CMake auto-detects headers and ignore them in source list, so it's only aesthetics.
denandz
pushed a commit
to denandz/curl
that referenced
this pull request
Jun 21, 2025
Move function to curlx/, change all callers. Also: - src: replace local implementation. - tests/client: replace local ad-hoc sleep code. - tests/libtest: replace local `wait_ms()` implementation. - lib1531: replace local ad-hoc sleep code. - tests/server: replace local, simplified copy. - tests/server: formatting, drop some unused headers. Closes curl#17641
vszakats
added a commit
to vszakats/curl
that referenced
this pull request
Jun 23, 2025
vszakats
added a commit
to vszakats/curl
that referenced
this pull request
Jun 23, 2025
17 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move function to curlx/, change all callers.
Also:
wait_ms()implementation.select_wrapper()has specialSleep()code for Windows, suggestingselect()is called from places to trigger a wait. Which callers may be doing that? (the first arg,int nfds == 0)Ref: e134a40
I don't know → SKIP in this PR.
wait_ms(). It's wrappingselect()into an error handling macro, otherwise it's a simpler version
of
curlx_wait_ms(). Change it to the latter? [DONE]The libtest-specific select wrapper is gone from
wait_mswith this. Was it necessary there? → The code suggest that it was not.select_wrapper()was dealing with Windows (USE_WINSOCK) the same waywait_msalready handled on its own.curlx_wait_ms().curl_setup.hand curlx (for fopen). fix printf fallouts. → tests/http/clients: drop hack and usecurl_setup.hagain #17642