Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

curl/system.h: support more architectures #1766

Closed
wants to merge 1 commit into from

Conversation

@tpetazzoni
Copy link
Contributor

commented Aug 11, 2017

The long list of architectures in include/curl/system.h is annoying to
maintain, and needs to be extended for each and every architecture to
support.

Instead, let's rely on the SIZEOF_LONG define of the gcc compiler
(we are in the GNUC condition anyway), which tells us if long is 4
bytes or 8 bytes.

This fixes the build of libcurl 7.55.0 on architectures such as
OpenRISC or ARC.

Signed-off-by: Thomas Petazzoni thomas.petazzoni@free-electrons.com

curl/system.h: support more architectures
The long list of architectures in include/curl/system.h is annoying to
maintain, and needs to be extended for each and every architecture to
support.

Instead, let's rely on the __SIZEOF_LONG__ define of the gcc compiler
(we are in the GNUC condition anyway), which tells us if long is 4
bytes or 8 bytes.

This fixes the build of libcurl 7.55.0 on architectures such as
OpenRISC or ARC.

Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
@coveralls

This comment has been minimized.

Copy link

commented Aug 11, 2017

Coverage Status

Coverage increased (+0.02%) to 75.095% when pulling 7d84bd8 on tpetazzoni:fix-system-h into 77cd4e7 on curl:master.

@bagder
bagder approved these changes Aug 11, 2017
@bagder

This comment has been minimized.

Copy link
Member

commented Aug 11, 2017

(the two CI failures are totally unrelated)

@bagder bagder closed this in 4ca5f77 Aug 11, 2017

@bagder

This comment has been minimized.

Copy link
Member

commented Aug 11, 2017

Thanks!

@lock lock bot locked as resolved and limited conversation to collaborators Jan 18, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
3 participants
You can’t perform that action at this time.