system.h: remove all CURL_SIZEOF_* defines#1767
Closed
bagder wants to merge 5 commits into
Closed
Conversation
8be8a01 to
4dfab82
Compare
Member
|
My opinion is CURL_SIZEOF_ for curl types is appropriate. Is there some reason not to have them, and couldn't this be addressed by just removing CURL_SIZEOF_LONG? |
Member
Author
|
I want to remove the SIZEOF defines from there because:
|
4dfab82 to
c486957
Compare
Member
Author
|
Rebased and fixed merge conflicts |
... as they're not used externally and internally we check for the sizes already in configure etc.
a5c139b to
6ccbdd1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
... as they're not used externally and internally we check for the sizes
already in configure etc.