system.h: remove all CURL_SIZEOF_* defines #1767

Closed
wants to merge 5 commits into
from

Conversation

Projects
None yet
3 participants
@bagder
Member

bagder commented Aug 11, 2017

... as they're not used externally and internally we check for the sizes
already in configure etc.

@jay

This comment has been minimized.

Show comment
Hide comment
@jay

jay Aug 13, 2017

Member

My opinion is CURL_SIZEOF_ for curl types is appropriate. Is there some reason not to have them, and couldn't this be addressed by just removing CURL_SIZEOF_LONG?

Member

jay commented Aug 13, 2017

My opinion is CURL_SIZEOF_ for curl types is appropriate. Is there some reason not to have them, and couldn't this be addressed by just removing CURL_SIZEOF_LONG?

@bagder

This comment has been minimized.

Show comment
Hide comment
@bagder

bagder Aug 13, 2017

Member

I want to remove the SIZEOF defines from there because:

  1. They're not necessary
  2. They're not used by any public header/functionality
  3. They make the system.h larger than it has to be, both in total and per system
Member

bagder commented Aug 13, 2017

I want to remove the SIZEOF defines from there because:

  1. They're not necessary
  2. They're not used by any public header/functionality
  3. They make the system.h larger than it has to be, both in total and per system
@bagder

This comment has been minimized.

Show comment
Hide comment
@bagder

bagder Aug 15, 2017

Member

Rebased and fixed merge conflicts

Member

bagder commented Aug 15, 2017

Rebased and fixed merge conflicts

bagder added some commits Aug 12, 2017

system.h: remove all CURL_SIZEOF_* defines
... as they're not used externally and internally we check for the sizes
already in configure etc.
@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Aug 16, 2017

Coverage Status

Coverage increased (+0.03%) to 75.08% when pulling 6ccbdd1 on bagder/system-h-remove-sizes into 75536e5 on master.

Coverage Status

Coverage increased (+0.03%) to 75.08% when pulling 6ccbdd1 on bagder/system-h-remove-sizes into 75536e5 on master.

@bagder bagder deleted a comment from coveralls Aug 16, 2017

@bagder bagder deleted a comment from coveralls Aug 16, 2017

@bagder bagder deleted a comment from coveralls Aug 16, 2017

@bagder bagder deleted a comment from coveralls Aug 16, 2017

@bagder bagder deleted a comment from coveralls Aug 16, 2017

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Aug 16, 2017

Coverage Status

Coverage increased (+0.01%) to 75.062% when pulling 4731802 on bagder/system-h-remove-sizes into 75536e5 on master.

Coverage Status

Coverage increased (+0.01%) to 75.062% when pulling 4731802 on bagder/system-h-remove-sizes into 75536e5 on master.

@bagder bagder closed this in 80d9e35 Aug 17, 2017

@bagder bagder deleted the bagder/system-h-remove-sizes branch Aug 17, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment