Skip to content

lib: make CURLX_SET_BINMODE() and use it #17672

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 10 commits into from

Conversation

vszakats
Copy link
Member

@vszakats vszakats commented Jun 19, 2025

Use it from libtests' first.c and thus also from units, and tunits.

Also:

  • cmake: drop stray curltool lib dependency for units.
  • units: stop depending on src headers.
  • tests/server: drop depending on src headers.
    (the remaining one listed in the comments, tool_xattr.h, was not
    actually used from servers.)
  • tests/server: drop duplicate curlx headers.
    (Except warnless.h, which is tricky on Windows.)

@vszakats vszakats closed this in 916f241 Jun 19, 2025
@vszakats vszakats deleted the curlx-binmode branch June 19, 2025 13:58
denandz pushed a commit to denandz/curl that referenced this pull request Jun 21, 2025
Use it from libtests' `first.c` and thus also from units, and tunits.

Also:
- cmake: drop stray `curltool` lib dependency for units.
- units: stop depending on `src` headers.
- tests/server: drop depending on `src` headers.
  (the remaining one listed in the comments, `tool_xattr.h`, was not
  actually used from servers.)
- tests/server: drop duplicate curlx headers.
  (Except `warnless.h`, which is tricky on Windows.)

Closes curl#17672
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

1 participant