lib: make CURLX_SET_BINMODE() and use it#17672
Closed
vszakats wants to merge 10 commits intocurl:masterfrom
Closed
lib: make CURLX_SET_BINMODE() and use it#17672vszakats wants to merge 10 commits intocurl:masterfrom
CURLX_SET_BINMODE() and use it#17672vszakats wants to merge 10 commits intocurl:masterfrom
Conversation
denandz
pushed a commit
to denandz/curl
that referenced
this pull request
Jun 21, 2025
Use it from libtests' `first.c` and thus also from units, and tunits. Also: - cmake: drop stray `curltool` lib dependency for units. - units: stop depending on `src` headers. - tests/server: drop depending on `src` headers. (the remaining one listed in the comments, `tool_xattr.h`, was not actually used from servers.) - tests/server: drop duplicate curlx headers. (Except `warnless.h`, which is tricky on Windows.) Closes curl#17672
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use it from libtests'
first.cand thus also from units, and tunits.Also:
curltoollib dependency for units.srcheaders.srcheaders.(the remaining one listed in the comments,
tool_xattr.h, was notactually used from servers.)
(Except
warnless.h, which is tricky on Windows.)