tests: drop useless "nodist_SOURCES" assignments#17688
Closed
Conversation
They cause automake warnings and have no effect.
vszakats
added a commit
to vszakats/curl
that referenced
this pull request
Jun 21, 2025
Derive of from `$BUNDLE`. autotools seems to be already relying on `$BUNDLE_SRC` being `$BUNDLE.c`. (I haven't realized this before aaebb45.) Also drop redundant `nodist_<target>_SOURCE` lines in units and tunits. Follow-up to aaebb45 curl#17688
vszakats
added a commit
to vszakats/curl
that referenced
this pull request
Jun 21, 2025
Derive it from `$BUNDLE` instead. autotools seems to be already relying on `$BUNDLE_SRC` being `$BUNDLE.c`. (I haven't realized this before aaebb45.) Also drop redundant `nodist_<target>_SOURCE` lines in units and tunits. Follow-up to aaebb45 curl#17688
vszakats
added a commit
that referenced
this pull request
Jun 21, 2025
Derive it from `$BUNDLE` instead. autotools seems to be already relying on `$BUNDLE_SRC` being equal to `$BUNDLE.c`. (I haven't realized this before aaebb45.) Also drop redundant `nodist_<target>_SOURCE` lines in tunits and units. Follow-up to aaebb45 #17688 Follow-up to 2c27a67 #17590 Closes #17692
denandz
pushed a commit
to denandz/curl
that referenced
this pull request
Jun 21, 2025
They cause automake warnings and have no effect. Closes curl#17688
denandz
pushed a commit
to denandz/curl
that referenced
this pull request
Jun 21, 2025
Derive it from `$BUNDLE` instead. autotools seems to be already relying on `$BUNDLE_SRC` being equal to `$BUNDLE.c`. (I haven't realized this before aaebb45.) Also drop redundant `nodist_<target>_SOURCE` lines in tunits and units. Follow-up to aaebb45 curl#17688 Follow-up to 2c27a67 curl#17590 Closes curl#17692
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
They cause automake warnings and have no effect.