Skip to content

top-complexity: lower max allowed complexity threshold to 90 #17689

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

bagder
Copy link
Member

@bagder bagder commented Jun 20, 2025

Down from 100. Also make it show all functions with complexity > 65 (down from 70).

Current output

./scripts/top-complexity

---- threshold: 90 ----

84    lib/setopt.c:setopt_long
83    src/tool_operate.c:single_transfer
80    src/config2setopts.c:config2setopts
79    lib/setopt.c:setopt_cptr
79    lib/vtls/openssl.c:cert_stuff
75    src/tool_cb_wrt.c:tool_write_cb
73    lib/socks.c:do_SOCKS5
72    lib/vssh/wolfssh.c:wssh_statemach_act
71    lib/vtls/wolfssl.c:Curl_wssl_ctx_init
71    lib/rtsp.c:rtsp_do
71    lib/socks_sspi.c:Curl_SOCKS5_gssapi_negotiate
70    lib/ftp.c:ftp_pp_statemachine
66    lib/http.c:Curl_http
66    lib/urlapi.c:parseurl

Down from 100. Also make it show all functions with complexity > 65
(down from 70).
@bagder bagder marked this pull request as ready for review June 20, 2025 21:33
@testclutch

This comment was marked as outdated.

@bagder bagder closed this in 84b6269 Jun 21, 2025
@bagder bagder deleted the bagder/complexity-90 branch June 21, 2025 08:52
denandz pushed a commit to denandz/curl that referenced this pull request Jun 21, 2025
Down from 100. Also make it show all functions with complexity > 65
(down from 70).

Closes curl#17689
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

2 participants