tests: drop unused or redundant includes#17717
Closed
vszakats wants to merge 26 commits intocurl:masterfrom
Closed
tests: drop unused or redundant includes#17717vszakats wants to merge 26 commits intocurl:masterfrom
vszakats wants to merge 26 commits intocurl:masterfrom
Conversation
This comment was marked as off-topic.
This comment was marked as off-topic.
vszakats
force-pushed
the
t-drop-unused-headers
branch
from
6ecca03 to
b7a8ab8
Compare
vszakats
changed the title
Also lots of tests were already relying on this.
Some #includes were unguarded. This suggests that this header is also fine to use without the feature guard and feature check. (It's a POSIX header)
Some were guarded just by HAVE_PTHREAD_H, instead of its own guard.
Found unguarded includes here as well.
vszakats
force-pushed
the
t-drop-unused-headers
branch
from
115cff6 to
73737b0
Compare
Member
Author
|
I've found it interesting that these headers (all POSIX) were used While the builds do the detections, and core code has the feature guards. There is a fair chance these feature checks are redundant. edit: |
vszakats
added a commit
that referenced
this pull request
Jun 24, 2025
It has been used unconditionally in `src` and `tests` since at least 2011-09-19 via fdecb56. There are earlier unguarded references in `tests`. Also de-duplicate to include it just once. Ref: #17717 (comment) Closes #17724
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
curltimefrom curlx #17716