Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

curl/system.h: GCC doesn't define __ppc__ on PowerPC, use __powerpc__ instead #1774

Closed
wants to merge 1 commit into from
Closed

curl/system.h: GCC doesn't define __ppc__ on PowerPC, use __powerpc__ instead #1774

wants to merge 1 commit into from

Conversation

alllexx88
Copy link
Contributor

There's a mistake in current system,h testing for generic PowerPC GCC. GCC doesn't define __ppc__ for PowerPC arch, but defines __powerpc__ instead. For instance, see here

@mention-bot
Copy link

@alllexx88, thanks for your PR! By analyzing the history of the files in this pull request, we identified @bagder, @MarcelRaad and @tpetazzoni to be potential reviewers.

@bagder
Copy link
Member

bagder commented Aug 13, 2017

Thanks! This may then also call for a bug report to predef.sf.net which says otherwise...

@coveralls
Copy link

Coverage Status

Coverage increased (+0.1%) to 75.147% when pulling f5be12e on alllexx88:ppc-system-h-fix into 6bde13a on curl:master.

@alllexx88
Copy link
Contributor Author

I've verified this on two powerpc toolchains. Without this patch I get multiple errors of this kind:

../include/curl/curl.h:174:3: error: unknown type name ‘curl_off_t’

(e.g., see http://jenkins.nas-admin.org/view/Optware/job/Optware_Build_006_buildroot-ppc-603e/389/console)

@bagder bagder closed this in 10b3df1 Aug 13, 2017
@bagder
Copy link
Member

bagder commented Aug 13, 2017

Thanks!

@alllexx88
Copy link
Contributor Author

You're welcome! Thanks for merging this

@alllexx88 alllexx88 deleted the ppc-system-h-fix branch August 13, 2017 16:23
@ryandesign ryandesign mentioned this pull request Aug 17, 2017
Closed
bagder added a commit that referenced this pull request Aug 17, 2017
@bagder
curl/system.h: check for __ppc__ as well
aa03f98 
... regression since issue #1774 (commit 10b3df1) since obviously
some older gcc doesn't know __powerpc__ while some newer doesn't know
__ppc__ ...

Fixes #1797
Reported-by: Ryan Schmidt
@bagder bagder mentioned this pull request Aug 17, 2017
Closed
bagder added a commit that referenced this pull request Aug 18, 2017
@bagder
curl/system.h: check for __ppc__ as well
f2d060c 
... regression since issue #1774 (commit 10b3df1) since obviously
some older gcc doesn't know __powerpc__ while some newer doesn't know
__ppc__ ...

Fixes #1797
Closes #1798
Reported-by: Ryan Schmidt
@lanurmi lanurmi mentioned this pull request May 7, 2018
Merged
@lock lock bot locked as resolved and limited conversation to collaborators Jan 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@alllexx88 @mention-bot @bagder @coveralls