http: fix build with cookies and HSTS disabled #17753
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All arguments and local variables in `http_header_s` were unused when both `CURL_DISABLE_COOKIES` and `CURL_DISABLE_HSTS` were defined. Closes curl#17753
There was a problem hiding this comment.
Pull Request Overview
This PR addresses a build issue when both CURL_DISABLE_COOKIES and CURL_DISABLE_HSTS are defined by adding preprocessor conditionals to avoid unused variable warnings.
- Added conditional compilation blocks to bypass unused variables.
- Introduced void casts for parameters in the disabled configuration.
MarcelRaad
force-pushed
the
fix_build_without_cookies_and_hsts
branch
from
b672e27 to
2a9dfe2
Compare
bagder
approved these changes
Jun 26, 2025
|
CI failures are failing tests and look unrelated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All arguments and local variables in
http_header_swere unused when bothCURL_DISABLE_COOKIESandCURL_DISABLE_HSTSwere defined.