Skip to content

travis: build the examples too#1777

Closed
bagder wants to merge 1 commit into
masterfrom
bagder/travis-examples
Closed

travis: build the examples too#1777
bagder wants to merge 1 commit into
masterfrom
bagder/travis-examples

Conversation

@bagder
Copy link
Copy Markdown
Member

@bagder bagder commented Aug 14, 2017

to make sure they keep building warning-free

to make sure they keep building warning-free
@coveralls
Copy link
Copy Markdown

Coverage Status

Coverage decreased (-0.03%) to 75.063% when pulling 4174dec on bagder/travis-examples into adc35a4 on master.

@MarcelRaad
Copy link
Copy Markdown
Member

Isn't --enable-werror only for the library and tool? IIRC, the examples and tests always build without warnings-as-errors. But keeping them building at all is an improvement too of course :-)

@bagder
Copy link
Copy Markdown
Member Author

bagder commented Aug 14, 2017

Yes, I'm mostly concerned that they build at all, I'm not at all convinced that --werror is a good idea for the examples.

@MarcelRaad
Copy link
Copy Markdown
Member

Ah, I misread the description to mean that. Yes, warnings-as-errors doesn't even work on Windows without complicating the examples because some WinSock function parameter is unsigned int when it should be size_t.

@bagder bagder closed this in b53b4e4 Aug 14, 2017
@bagder bagder deleted the bagder/travis-examples branch August 14, 2017 21:26
@bagder
Copy link
Copy Markdown
Member Author

bagder commented Aug 14, 2017

Thanks for the review @MarcelRaad

@lock lock Bot locked as resolved and limited conversation to collaborators Jan 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants