travis: build the examples too #1777

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
3 participants
@bagder
Member

bagder commented Aug 14, 2017

to make sure they keep building warning-free

travis: build the examples too
to make sure they keep building warning-free
@coveralls

This comment has been minimized.

Show comment Hide comment
@coveralls

coveralls Aug 14, 2017

Coverage Status

Coverage decreased (-0.03%) to 75.063% when pulling 4174dec on bagder/travis-examples into adc35a4 on master.

Coverage Status

Coverage decreased (-0.03%) to 75.063% when pulling 4174dec on bagder/travis-examples into adc35a4 on master.

@MarcelRaad

This comment has been minimized.

Show comment Hide comment
@MarcelRaad

MarcelRaad Aug 14, 2017

Member

Isn't --enable-werror only for the library and tool? IIRC, the examples and tests always build without warnings-as-errors. But keeping them building at all is an improvement too of course :-)

Member

MarcelRaad commented Aug 14, 2017

Isn't --enable-werror only for the library and tool? IIRC, the examples and tests always build without warnings-as-errors. But keeping them building at all is an improvement too of course :-)

@bagder

This comment has been minimized.

Show comment Hide comment
@bagder

bagder Aug 14, 2017

Member

Yes, I'm mostly concerned that they build at all, I'm not at all convinced that --werror is a good idea for the examples.

Member

bagder commented Aug 14, 2017

Yes, I'm mostly concerned that they build at all, I'm not at all convinced that --werror is a good idea for the examples.

@MarcelRaad

This comment has been minimized.

Show comment Hide comment
@MarcelRaad

MarcelRaad Aug 14, 2017

Member

Ah, I misread the description to mean that. Yes, warnings-as-errors doesn't even work on Windows without complicating the examples because some WinSock function parameter is unsigned int when it should be size_t.

Member

MarcelRaad commented Aug 14, 2017

Ah, I misread the description to mean that. Yes, warnings-as-errors doesn't even work on Windows without complicating the examples because some WinSock function parameter is unsigned int when it should be size_t.

@bagder bagder closed this in b53b4e4 Aug 14, 2017

@bagder bagder deleted the bagder/travis-examples branch Aug 14, 2017

@bagder

This comment has been minimized.

Show comment Hide comment
@bagder

bagder Aug 14, 2017

Member

Thanks for the review @MarcelRaad

Member

bagder commented Aug 14, 2017

Thanks for the review @MarcelRaad

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment