Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign uptravis: build the examples too #1777
Conversation
This comment has been minimized.
This comment has been minimized.
coveralls
commented
Aug 14, 2017
This comment has been minimized.
This comment has been minimized.
|
Isn't |
This comment has been minimized.
This comment has been minimized.
|
Yes, I'm mostly concerned that they build at all, I'm not at all convinced that |
This comment has been minimized.
This comment has been minimized.
|
Ah, I misread the description to mean that. Yes, warnings-as-errors doesn't even work on Windows without complicating the examples because some WinSock function parameter is |
MarcelRaad
approved these changes
Aug 14, 2017
bagder
closed this
in
b53b4e4
Aug 14, 2017
bagder
deleted the
bagder/travis-examples
branch
Aug 14, 2017
This comment has been minimized.
This comment has been minimized.
|
Thanks for the review @MarcelRaad |
lock
bot
locked as resolved and limited conversation to collaborators
Jan 18, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
bagder commentedAug 14, 2017
to make sure they keep building warning-free