Skip to content

CURLOPT: drop redundant long casts#17791

Closed
vszakats wants to merge 23 commits intocurl:masterfrom
vszakats:drop-long-casts
Closed

CURLOPT: drop redundant long casts#17791
vszakats wants to merge 23 commits intocurl:masterfrom
vszakats:drop-long-casts

Conversation

@vszakats
Copy link
Member

@vszakats vszakats commented Jul 1, 2025

Also:

  • CURLOPT_HSTS_CTRL.md: sync macro definitions with curl/curl.h.
    Perhaps it'd be better to delete copies like this?
  • keep existing casts within the documentation to make sure it applies
    to older curl versions as well.
  • CURLOPT_IPRESOLVE.md: re-add a long cast to man page, for consistency
    with the above.

@vszakats vszakats marked this pull request as draft July 1, 2025 10:49
@vszakats vszakats changed the title drop long casts, make some macros long CURLOPT: drop redundant long casts Jul 1, 2025
@vszakats vszakats changed the title CURLOPT: drop redundant long casts CURLOPT: drop redundant long casts Jul 1, 2025
@bagder
Copy link
Member

bagder commented Jul 1, 2025

I left them in the docs previously just because they were needed previously and people with older libcurl installations may read the newer documentation...

@bagder
Copy link
Member

bagder commented Jul 1, 2025

Not saying we can't do this, but it needs a think.

@vszakats
Copy link
Member Author

vszakats commented Jul 1, 2025

I left them in the docs previously just because they were needed previously and people with older libcurl installations may read the newer documentation...

Yes, it'd probably be a reasonable thing to keep in-doc code (and perhaps examples?) backwards compatible. Though it makes maintenance more involved. Existing docs did not look conclusive, so went ahead to see how it'd look without this in mind.

If we want to do it consistently, it'll need fixing the other way around.

@vszakats vszakats marked this pull request as ready for review July 7, 2025 12:40
@vszakats vszakats added the feature-window A merge of this requires an open feature window label Jul 7, 2025
@vszakats vszakats force-pushed the drop-long-casts branch 2 times, most recently from 80145c3 to 98650ed Compare July 27, 2025 20:43
@vszakats vszakats closed this in 5debe7c Jul 28, 2025
@vszakats vszakats deleted the drop-long-casts branch July 28, 2025 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cmdline tool feature-window A merge of this requires an open feature window libcurl API tests

Development

Successfully merging this pull request may close these issues.

2 participants

Comments