CURLOPT: drop redundant long casts#17791
Closed
vszakats wants to merge 23 commits intocurl:masterfrom
Closed
Conversation
long casts
Member
|
I left them in the docs previously just because they were needed previously and people with older libcurl installations may read the newer documentation... |
Member
|
Not saying we can't do this, but it needs a think. |
Member
Author
Yes, it'd probably be a reasonable thing to keep in-doc code (and perhaps examples?) backwards compatible. Though it makes maintenance more involved. Existing docs did not look conclusive, so went ahead to see how it'd look without this in mind. If we want to do it consistently, it'll need fixing the other way around. |
80145c3 to
98650ed
Compare
7ed833b to
6770ab7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also:
curl/curl.h.Perhaps it'd be better to delete copies like this?
to older curl versions as well.
with the above.