cmake/FindGSS: fix processing C header path options #17805
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vszakats
changed the title
It'd be nice to do, but it trips `cmake-lint`. ``` FindGSS.cmake:55,04: [C0103] Invalid directory variable name "_GSS_CFLAGS" doesn't match `[A-Z][0-9A-Z_]+|_[0-9a-z_]+` FindGSS.cmake:56,04: [C0103] Invalid directory variable name "_GSS_LIBRARY_DIRS" doesn't match `[A-Z][0-9A-Z_]+|_[0-9a-z_]+` FindGSS.cmake:93,08: [C0103] Invalid directory variable name "_GSS_INCLUDE_DIRS" doesn't match `[A-Z][0-9A-Z_]+|_[0-9a-z_]+` FindGSS.cmake:94,08: [C0103] Invalid directory variable name "_GSS_LIBRARIES" doesn't match `[A-Z][0-9A-Z_]+|_[0-9a-z_]+` ``` The fix is a little more complex and better be done in a separate commit for sensible diffs.
vszakats
added a commit
to vszakats/curl
that referenced
this pull request
Jul 3, 2025
When processing `--cflags` received from `krb5-config` for `gssapi`: - fix to not break on multiple `-I` options. Before this patch only the first `-I` option was processed as a header directory, subsequent ones ended up in C flags as a raw directory, without the `-I` part. Follow-up to 558814e - fix to not duplicate C flags. Regression from 1467597 curl#14430 - drop local variable `_val` by re-using `_flag`. - tidy up comments. Ref: curl#17802 (comment) Closes curl#17805
This was referenced Jul 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When processing
--cflagsreceived fromkrb5-configforgssapi:fix to not break on multiple
-Ioptions. Before this patch onlythe first
-Ioption was processed as a header directory, subsequentones ended up in C flags as a raw directory, without the
-Iarg.Follow-up to 558814e
fix to not duplicate C flags.
Regression from 1467597 cmake: fix
pkg-config-based detection inFindGSS.cmake#14430drop local variable
_valby re-using_flag.tidy up comments.
Ref: #17802 (comment)
it needs quite a bit of renaming to avoid tripping
cmake-lint. → cmake/FindGSS: initialize result variables #17806