tool1621: drop unused internal libcurl headers #17811
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixing this error with PR 16973 applied:
```
[4/4] Processing file /Users/runner/work/curl/curl/tests/tunit/tool1621.c.
1 error generated.
Error while processing /Users/runner/work/curl/curl/tests/tunit/tool1621.c.
/Users/runner/work/curl/curl/lib/psl.h:28:10: error: 'libpsl.h' file not found [clang-diagnostic-error]
28 | #include <libpsl.h>
| ^~~~~~~~~~
FAILED: [code=1] tests/tunit/CMakeFiles/tunits-clang-tidy /Users/runner/work/curl/curl/bld/tests/tunit/CMakeFiles/tunits-clang-tidy
```
https://github.com/curl/curl/actions/runs/16055441393/job/45308545907?pr=16973#step:14:539
The applied PR remove dependency header directories from the global
scope, which means they are no longer passed to the tunits build.
Correctly so, but this also revealed that tool1621 was in fact depending
on dependency headers via internal libcurl header that were included.
These headers weren't used, so just drop them as a fix.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
curl_add_clang_tidy_test_target()to detect header directories(perhaps also compile definitions) in dependencies recursively.
To address the root cause seen with PR 16973 applied. → b7d9db3 → cmake: gather options recursively in
curl_add_clang_tidy_test_target#17812curl_add_clang_tidy_test_target#17812. [It's okay, no need]