tests: move curlcheck.h to libtest as unitcheck.h#17868
Closed
vszakats wants to merge 5 commits intocurl:masterfrom
Closed
tests: move curlcheck.h to libtest as unitcheck.h#17868vszakats wants to merge 5 commits intocurl:masterfrom
curlcheck.h to libtest as unitcheck.h#17868vszakats wants to merge 5 commits intocurl:masterfrom
Conversation
To make units and tunits depend on the same dir. Also, curlcheck.h depends on first.c and test.h in libtests, so even though it's not made for actual libtests, the logic resides there.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To simplify dependencies, and sync tunits and units builds further.
curlcheck.halready depended on logic implemented within libtests:it referenced a global variable (
unitfail) defined infirst.canddeclared in
test.h.Also:
unitcheck.hto indicate it's meant for unit tests.unitcheck.hincludefirst.hinstead oftest.h.This brings header use closer to libtests. It also includes
curlx/curlx.hfor all unit tests by default now.unitfaildeclaration fromtest.htofirst.h.To match its definition in
first.c.