scripts: enable strict warnings in Perl where missing, fix fallouts#17877
Closed
vszakats wants to merge 65 commits intocurl:masterfrom
Closed
scripts: enable strict warnings in Perl where missing, fix fallouts#17877vszakats wants to merge 65 commits intocurl:masterfrom
vszakats wants to merge 65 commits intocurl:masterfrom
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
vszakats
added a commit
to vszakats/curl
that referenced
this pull request
Jul 9, 2025
Fix test1175 to pass the correct source root directory. Before this patch this caused a silent failure and the tests didn't run. With this fixed, it detected these issues: ``` CURLE_FUNCTION_NOT_FOUND is not in libcurl-errors.md CURLE_HTTP_POST_ERROR is not in libcurl-errors.md CURLE_TELNET_OPTION_SYNTAX is not in libcurl-errors.md CURLM_CALL_MULTI_SOCKET is not in libcurl-errors.md ``` Fix them by: - marking `CURLE_FUNCTION_NOT_FOUND` deprecated by 7.53.0 - marking `CURLE_HTTP_POST_ERROR` deprecated by 7.56.0 - marking `CURLE_TELNET_OPTION_SYNTAX` deprecated by 7.78.0 - documenting `CURLM_CALL_MULTI_SOCKET` as a synonym for `CURLM_CALL_MULTI_PERFORM` But, these weren't officially deprecated. It may need more updates to reflect that in other places, or fix the issues differently. Cherry-picked from curl#17877
vszakats
force-pushed
the
perl-w-fatal
branch
2 times, most recently
from
9c7f62c to
f90e62d
Compare
vszakats
added a commit
that referenced
this pull request
Jul 11, 2025
Fix test 1175 by passing the source root directory (was: tests). Before this patch this caused silent Perl warnings and returning success without executing the tests, due to: ``` readline() on closed filehandle $f at ../../tests/test1175.pl line 55. readline() on closed filehandle $f at ../../tests/test1175.pl line 39. ``` Running the test revealed these issues: ``` CURLE_FUNCTION_NOT_FOUND is not in libcurl-errors.md CURLE_HTTP_POST_ERROR is not in libcurl-errors.md CURLE_TELNET_OPTION_SYNTAX is not in libcurl-errors.md CURLM_CALL_MULTI_SOCKET is not in libcurl-errors.md ``` Apply fixes: - mark `CURLE_FUNCTION_NOT_FOUND` deprecated by 7.53.0 - mark `CURLE_HTTP_POST_ERROR` deprecated by 7.56.0 - mark `CURLE_TELNET_OPTION_SYNTAX` deprecated by 7.78.0 - document `CURLM_CALL_MULTI_SOCKET` as a synonym for `CURLM_CALL_MULTI_PERFORM` - test1477: exclude `CURLM_CALL_MULTI_SOCKET`. But, these weren't officially deprecated. It may need more updates to reflect that in other places, or fix the issues differently. Follow-up to 66ec950 #12424 Follow-up to 74f441c #4628 Cherry-picked from #17877 Closes #17880
Closed
vszakats
changed the title
vszakats
added a commit
to vszakats/curl
that referenced
this pull request
Jul 11, 2025
Replacing a regex, for portability. Cherry-picked from curl#17877
This was referenced Jul 11, 2025
vszakats
added a commit
that referenced
this pull request
Jul 12, 2025
vszakats
added a commit
that referenced
this pull request
Jul 14, 2025
Replacing a regex, for portability. Reported-by: Stefan Eissing Bug: #17871 (comment) Cherry-picked from #17877 Closes #17900
vszakats
changed the title
vszakats
added a commit
to vszakats/curl
that referenced
this pull request
Jul 14, 2025
Cherry-picked from curl#17877
Fixing: ``` check https://codepoints.net/U+00DF FAIL docs/URL-SYNTAX.md:199 ERROR links to missing URL https://codepoints.net/U+00DF ```
This was referenced Jul 27, 2025
vszakats
added a commit
that referenced
this pull request
Jul 28, 2025
Also fix possibly missing reallocated memory from 'Total allocated': ``` Use of uninitialized value $size in addition (+) at tests/memanalyze.pl line 240, <$fileh> line 4. ``` Ref: https://github.com/curl/curl/actions/runs/16565283280/job/46843800711?pr=18049#step:39:3834 Ref: https://github.com/curl/curl/actions/runs/16556860012/job/46819517495?pr=17927#step:39:156 Follow-up to fc98a63 #18048 Follow-up to 2ec5455 #17877 Closes #18049
vszakats
added a commit
that referenced
this pull request
Jul 28, 2025
vszakats
added a commit
that referenced
this pull request
Jul 30, 2025
AM libressl heimdal: ``` Global symbol "$verbose" requires explicit package name (did you forget to declare "my $verbose"?) at tests/http2-server.pl line 52. Global symbol "$certfile" requires explicit package name (did you forget to declare "my $certfile"?) at tests/http2-server.pl line 109. Global symbol "$keyfile" requires explicit package name (did you forget to declare "my $keyfile"?) at tests/http2-server.pl line 110. Execution of tests/http2-server.pl aborted due to compilation errors. [...] ``` Ref: https://github.com/curl/curl/actions/runs/16622030370/job/47028537336?pr=18099#step:39:3148 Follow-up to 2ec5455 #17877 Closes #18100
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Most actual errors found during this PR were fixed and merged via
separate PRs.
Likely there are remaining warnings not found and fixed in this PR.
managenfor out-of-tree builds #17926