test1175: fix to run, and fix documentation issues detected#17880
Closed
vszakats wants to merge 5 commits into
Closed
test1175: fix to run, and fix documentation issues detected#17880vszakats wants to merge 5 commits into
vszakats wants to merge 5 commits into
Conversation
Fix test1175 to pass the correct source root directory. Before this patch this caused a silent failure and the tests didn't run. With this fixed, it detected these issues: ``` CURLE_FUNCTION_NOT_FOUND is not in libcurl-errors.md CURLE_HTTP_POST_ERROR is not in libcurl-errors.md CURLE_TELNET_OPTION_SYNTAX is not in libcurl-errors.md CURLM_CALL_MULTI_SOCKET is not in libcurl-errors.md ``` Fix them by: - marking `CURLE_FUNCTION_NOT_FOUND` deprecated by 7.53.0 - marking `CURLE_HTTP_POST_ERROR` deprecated by 7.56.0 - marking `CURLE_TELNET_OPTION_SYNTAX` deprecated by 7.78.0 - documenting `CURLM_CALL_MULTI_SOCKET` as a synonym for `CURLM_CALL_MULTI_PERFORM` But, these weren't officially deprecated. It may need more updates to reflect that in other places, or fix the issues differently. Cherry-picked from curl#17877
vszakats
changed the title
This comment was marked as resolved.
This comment was marked as resolved.
It's regex is not picking it up from multi.h because it's a #define, not an enum with an indent.
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix test 1175 by passing the source root directory (was: tests).
Before this patch this caused silent Perl warnings and returning success
without executing the tests, due to:
Running the test revealed these issues:
Apply fixes:
CURLE_FUNCTION_NOT_FOUNDdeprecated by 7.53.0CURLE_HTTP_POST_ERRORdeprecated by 7.56.0CURLE_TELNET_OPTION_SYNTAXdeprecated by 7.78.0CURLM_CALL_MULTI_SOCKETas a synonym forCURLM_CALL_MULTI_PERFORMCURLM_CALL_MULTI_SOCKET.But, these weren't officially deprecated. It may need more updates
to reflect that in other places, or fix the issues differently.
Follow-up to 66ec950 #12424
Follow-up to 74f441c #4628
Cherry-picked from #17877