Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign uphttp_proxy: a compilation error was fixed #1793
Closed
Conversation
This comment has been minimized.
This comment has been minimized.
coveralls
commented
Aug 16, 2017
This comment has been minimized.
This comment has been minimized.
|
Thanks |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
majstar commentedAug 16, 2017
Hello.
I faced a compilation error when was building cURL with CURL_DOES_CONVERSIONS defined. The problem occurred because some variables in curl/lib/http_proxy.c were moved to the structure http_connect_state in 5113ad0.
The issue is present only when CURL_DOES_CONVERSIONS defined because, otherwise, calls of Curl_convert_from_network are removed from the code at the preprocessing stage.