Skip to content

http_proxy: a compilation error was fixed#1793

Closed
majstar wants to merge 1 commit into
curl:masterfrom
majstar:master
Closed

http_proxy: a compilation error was fixed#1793
majstar wants to merge 1 commit into
curl:masterfrom
majstar:master

Conversation

@majstar
Copy link
Copy Markdown
Contributor

@majstar majstar commented Aug 16, 2017

Hello.
I faced a compilation error when was building cURL with CURL_DOES_CONVERSIONS defined. The problem occurred because some variables in curl/lib/http_proxy.c were moved to the structure http_connect_state in 5113ad0.
The issue is present only when CURL_DOES_CONVERSIONS defined because, otherwise, calls of Curl_convert_from_network are removed from the code at the preprocessing stage.

@coveralls
Copy link
Copy Markdown

Coverage Status

Coverage decreased (-0.04%) to 73.162% when pulling fd80201 on majstar:master into ca9630f on curl:master.

@jay jay closed this in 801d876 Aug 16, 2017
@jay
Copy link
Copy Markdown
Member

jay commented Aug 16, 2017

Thanks

@jay jay added the build label Aug 16, 2017
@lock lock Bot locked as resolved and limited conversation to collaborators May 14, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Development

Successfully merging this pull request may close these issues.

3 participants