New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

http_proxy: a compilation error was fixed #1793

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
3 participants
@majstar
Contributor

majstar commented Aug 16, 2017

Hello.
I faced a compilation error when was building cURL with CURL_DOES_CONVERSIONS defined. The problem occurred because some variables in curl/lib/http_proxy.c were moved to the structure http_connect_state in 5113ad0.
The issue is present only when CURL_DOES_CONVERSIONS defined because, otherwise, calls of Curl_convert_from_network are removed from the code at the preprocessing stage.

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Aug 16, 2017

Coverage Status

Coverage decreased (-0.04%) to 73.162% when pulling fd80201 on majstar:master into ca9630f on curl:master.

coveralls commented Aug 16, 2017

Coverage Status

Coverage decreased (-0.04%) to 73.162% when pulling fd80201 on majstar:master into ca9630f on curl:master.

@jay jay closed this in 801d876 Aug 16, 2017

@jay

This comment has been minimized.

Show comment
Hide comment
@jay

jay Aug 16, 2017

Member

Thanks

Member

jay commented Aug 16, 2017

Thanks

@jay jay added the build label Aug 16, 2017

@lock lock bot locked as resolved and limited conversation to collaborators May 14, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.