test1560: set locale/codeset with LC_ALL (was: LANG), test in CI#17938
test1560: set locale/codeset with LC_ALL (was: LANG), test in CI#17938vszakats wants to merge 7 commits into
LC_ALL (was: LANG), test in CI#17938Conversation
|
My understanding is that This issue reproduces in GHA/linux after adding an https://github.com/curl/curl/actions/runs/16302695675/job/46041044747?pr=17938#step:42:3039 Once enabling libidn2 in Ubuntu jobs (with LDAP), it reproduces there too: https://github.com/curl/curl/actions/runs/16303028718/job/46042184742?pr=17938#step:41:3003 |
This comment was marked as resolved.
This comment was marked as resolved.
vszakats
changed the title
LC_ALLLC_ALL
vszakats
changed the title
LC_ALLLC_ALL (was: LANG)
vszakats
changed the title
LC_ALL (was: LANG)LC_ALL (was: LANG), test in CI
- runtests: fix `codeset-utf8` feature detection. Before this patch it detected if the calling environment had UTF-8 enabled. If not, UTF-8 tests were all skipped. After this patch, it detects if UTF-8 is supported by the calling environment regardless of what's currently enabled. Follow-up to 0b70b23 #15039 - GHA/linux: sync `codeset-test` to also reset `LC_CTYPE` and `LC_NUMBER`. To give it more spin. Follow-up to c221c0e #17938 - GHA/macos: fix to actually enable `codeset-test`. Also set `LC_ALL`, which seems necessary to trigger issues. Follow-up to c221c0e #17938 - tests/data: replace `LC_CTYPE` env with `LC_ALL` in all tests requiring a locale. Also to avoid potential issues with a blank or unset `LC_ALL`, as seen earlier. And to ensure that the override works on all platforms (as tested in CI.) Slight downside is that this now resets the language/culture to `C`. Ref: b4c9982 #4743 Ref: 23208e3 #4738 - replace `en_US.UTF-8` with `C.UTF-8` to be language/culture-agnostic. - TEST-SUITE.md: drop `UTF-8` as a requirement for tests. Tests shall work (or least be skipped) without UTF-8 support. Tests requiring UTF-8 locale: 165, 962, 963, 964, 965, 966, 967, 1448, 1560, 2046, 2047 Tests requiring UTF-8 locale, but passing without one anyway: 955, 956, 957, 958, 959, 960, 961, 968, 1034, 1035 Spec 1997: https://pubs.opengroup.org/onlinepubs/7908799/xbd/envvar.html Spec 2008: https://pubs.opengroup.org/onlinepubs/9699919799/basedefs/V1_chap08.html Ref: c221c0e #17938 Ref: 7cf8414 Ref: 4c140a5 Ref: 28faaac #2436 Ref: ecd1d02 Closes #17988
3 participants
To fix running test 1560 when
LC_ALLis set to something unexpected(e.g.
C). Also syncing it with the rest of tests.Also:
libidn2in more jobs.Also to enable test 1560 reproducing this issue in more jobs.
LC_ALL=Cin one of the jobs.Ref: #17933 (comment)
Follow-up to f27262b #10196
LC_*variables in tests to another PR. → tests: fix UTF-8 detection, per-testLC_*settings, CI coverage #17988LC_ALL=CGHA/macos to a single job like in Linux.