New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

darwinssl: add support for TLSv1.3 #1794

Merged
merged 1 commit into from Oct 5, 2017

Conversation

Projects
None yet
4 participants
@nickzman
Collaborator

nickzman commented Aug 16, 2017

This is for a feature Apple has publicly announced and documented, but
it's still technically in beta, since it requires Xcode 9.x to build,
and iOS 11 or macOS 10.13 to use the feature. We should probably hold
off on merging this change until the gold masters are released.

darwinssl: add support for TLSv1.3
This is for a feature Apple has publicly announced and documented, but
it's still technically in beta, since it requires Xcode 9.x to build,
and iOS 11 or macOS 10.13 to use the feature. We should probably hold
off on merging this change until the gold masters are released.

@nickzman nickzman requested a review from bagder Aug 16, 2017

@coveralls

This comment has been minimized.

coveralls commented Aug 16, 2017

Coverage Status

Coverage increased (+0.02%) to 73.168% when pulling 24e76c1 on nickzman/darwinssl-tlsv1.3 into 870d849 on master.

@bagder

bagder approved these changes Aug 23, 2017

LGTM!

@nickzman nickzman merged commit 24e76c1 into master Oct 5, 2017

2 of 3 checks passed

continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
coverage/coveralls Coverage increased (+0.02%) to 73.168%
Details

jay added a commit that referenced this pull request Oct 5, 2017

@jay

This comment has been minimized.

Member

jay commented Oct 5, 2017

Thanks for your work on this, but it did not land in the appropriate way. It came with two merge commits (which we don't use in master) and the commit message was outdated and lacking a reference. The way to do this in curl project style would be rebase on master and squash the fixup. I force-pushed that just now in 3e492e0, it is identical to your changes but without the other three commits.

@bagder bagder deleted the nickzman/darwinssl-tlsv1.3 branch Jan 28, 2018

@lock lock bot locked as resolved and limited conversation to collaborators May 5, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.