Skip to content

darwinssl: add support for TLSv1.3#1794

Merged
nickzman merged 1 commit into
masterfrom
nickzman/darwinssl-tlsv1.3
Oct 5, 2017
Merged

darwinssl: add support for TLSv1.3#1794
nickzman merged 1 commit into
masterfrom
nickzman/darwinssl-tlsv1.3

Conversation

@nickzman

Copy link
Copy Markdown
Member

This is for a feature Apple has publicly announced and documented, but
it's still technically in beta, since it requires Xcode 9.x to build,
and iOS 11 or macOS 10.13 to use the feature. We should probably hold
off on merging this change until the gold masters are released.

This is for a feature Apple has publicly announced and documented, but
it's still technically in beta, since it requires Xcode 9.x to build,
and iOS 11 or macOS 10.13 to use the feature. We should probably hold
off on merging this change until the gold masters are released.
@nickzman
nickzman requested a review from bagder August 16, 2017 18:06
@coveralls

Copy link
Copy Markdown

Coverage Status

Coverage increased (+0.02%) to 73.168% when pulling 24e76c1 on nickzman/darwinssl-tlsv1.3 into 870d849 on master.

@bagder bagder left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@nickzman
nickzman merged commit 24e76c1 into master Oct 5, 2017
jay pushed a commit that referenced this pull request Oct 5, 2017
@jay

jay commented Oct 5, 2017

Copy link
Copy Markdown
Member

Thanks for your work on this, but it did not land in the appropriate way. It came with two merge commits (which we don't use in master) and the commit message was outdated and lacking a reference. The way to do this in curl project style would be rebase on master and squash the fixup. I force-pushed that just now in 3e492e0, it is identical to your changes but without the other three commits.

@bagder
bagder deleted the nickzman/darwinssl-tlsv1.3 branch January 28, 2018 13:56
@lock lock Bot locked as resolved and limited conversation to collaborators May 5, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants