Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign updarwinssl: add support for TLSv1.3 #1794
Conversation
nickzman
requested a review
from
bagder
Aug 16, 2017
This comment has been minimized.
This comment has been minimized.
coveralls
commented
Aug 16, 2017
nickzman
merged commit 24e76c1
into
master
Oct 5, 2017
added a commit
that referenced
this pull request
Oct 5, 2017
This comment has been minimized.
This comment has been minimized.
|
Thanks for your work on this, but it did not land in the appropriate way. It came with two merge commits (which we don't use in master) and the commit message was outdated and lacking a reference. The way to do this in curl project style would be rebase on master and squash the fixup. I force-pushed that just now in 3e492e0, it is identical to your changes but without the other three commits. |
bagder
deleted the
nickzman/darwinssl-tlsv1.3
branch
Jan 28, 2018
lock
bot
locked as resolved and limited conversation to collaborators
May 5, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
nickzman commentedAug 16, 2017
This is for a feature Apple has publicly announced and documented, but
it's still technically in beta, since it requires Xcode 9.x to build,
and iOS 11 or macOS 10.13 to use the feature. We should probably hold
off on merging this change until the gold masters are released.