connectdata: remove primary+secondary ip_quadruple#17960
Closed
icing wants to merge 6 commits intocurl:masterfrom
Closed
connectdata: remove primary+secondary ip_quadruple#17960icing wants to merge 6 commits intocurl:masterfrom
icing wants to merge 6 commits intocurl:masterfrom
Conversation
vszakats
reviewed
Jul 18, 2025
| else | ||
| #endif | ||
| DEBUGASSERT(Curl_conn_http_version(data, conn) == 20); | ||
| DEBUGASSERT(Curl_conn_http_version(data, conn) == 20); |
Member
There was a problem hiding this comment.
Hm, the line belongs to the else branch, depending on config. I wonder if there is a way to make this more clear. Perhaps dulicate the line to make it more explicit?
Contributor
Author
There was a problem hiding this comment.
Not sure myself how this is supposed to work/what is exactly checked. But that is outside of what this PR changes. I'd like to keep this out of here.
bagder
reviewed
Jul 28, 2025
Since the content varies during connection setup and while doing it (eyeballing), remove these strcut from `connectdata` and replace use with querying the connection filters. Those keep that information already. Change the info logging of established connections to also give the local address and port.
bagder
approved these changes
Jul 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since the content varies during connection setup and while doing it (eyeballing), remove these strcut from
connectdataand replace use with querying the connection filters. Those keep that information already.Change the info logging of established connections to also give the local address and port.