Skip to content

windows: target version macro tidy-ups#17981

Closed
vszakats wants to merge 11 commits intocurl:masterfrom
vszakats:w-tidy-ver
Closed

windows: target version macro tidy-ups#17981
vszakats wants to merge 11 commits intocurl:masterfrom
vszakats:w-tidy-ver

Conversation

@vszakats
Copy link
Member

@vszakats vszakats commented Jul 20, 2025

  • autotools: stop checking for WINVER to detect thread-safety.
    To sync with implementation in easy_lock.h and with cmake.

  • replace numeric version with _WIN32_WINNT_VISTA.

  • _WIN32_WINNT_VISTA is always defined via setup-win32.h,
    don't check for it.

@vszakats vszakats added build Windows Windows-specific tidy-up labels Jul 20, 2025
@vszakats vszakats changed the title windows: version macro tidy-ups windows: version macro tidy-ups, stop using WINVER Jul 20, 2025
@vszakats vszakats changed the title windows: version macro tidy-ups, stop using WINVER windows: version macro tidy-ups Jul 21, 2025
@vszakats
Copy link
Member Author

I backed off of deleting WINVER checks around the declaration
hack for IDN functions (and the WINVER assignment from curl_setup.h
with it). It's probably unnecessary, passes CI, but it's a murky area.

This could be done safely if requiring Vista, allowing to drop the
IDN declaration hack.

@vszakats vszakats changed the title windows: version macro tidy-ups windows: target version macro tidy-ups Jul 23, 2025
@vszakats vszakats closed this in 24f8442 Jul 23, 2025
@vszakats vszakats deleted the w-tidy-ver branch July 23, 2025 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

1 participant