New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmake: test for and enable picky compiler options #1799

Closed
wants to merge 2 commits into
base: master
from

Conversation

Projects
None yet
3 participants
@bagder
Member

bagder commented Aug 17, 2017

No description provided.

@bagder bagder added the cmake label Aug 17, 2017

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Aug 17, 2017

Coverage Status

Coverage increased (+0.03%) to 73.228% when pulling 0870d6b on bagder/cmake-picky-options into 6b9bc5a on master.

coveralls commented Aug 17, 2017

Coverage Status

Coverage increased (+0.03%) to 73.228% when pulling 0870d6b on bagder/cmake-picky-options into 6b9bc5a on master.

@MarcelRaad

This comment has been minimized.

Show comment
Hide comment
@MarcelRaad

MarcelRaad Aug 17, 2017

Member

I like the default being on, but that's probably only a good idea for GCC-compatible compilers - -Wall for Visual Studio is the same as -Weverything for clang.

Member

MarcelRaad commented Aug 17, 2017

I like the default being on, but that's probably only a good idea for GCC-compatible compilers - -Wall for Visual Studio is the same as -Weverything for clang.

@bagder

This comment has been minimized.

Show comment
Hide comment
@bagder

bagder Aug 17, 2017

Member

that explains the massive breakage on Windows... =)

Member

bagder commented Aug 17, 2017

that explains the massive breakage on Windows... =)

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Aug 18, 2017

Coverage Status

Coverage increased (+0.02%) to 73.224% when pulling 6e12ee9 on bagder/cmake-picky-options into 6b9bc5a on master.

coveralls commented Aug 18, 2017

Coverage Status

Coverage increased (+0.02%) to 73.224% when pulling 6e12ee9 on bagder/cmake-picky-options into 6b9bc5a on master.

@bagder bagder closed this in b939542 Aug 20, 2017

@bagder bagder deleted the bagder/cmake-picky-options branch Aug 20, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment