tests: unset some envs instead of blanking them#17994
Closed
vszakats wants to merge 2 commits intocurl:masterfrom
Closed
tests: unset some envs instead of blanking them#17994vszakats wants to merge 2 commits intocurl:masterfrom
vszakats wants to merge 2 commits intocurl:masterfrom
Conversation
vszakats
changed the title
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After 7cf8414 #12862,
VAR=no longerremoves the env variable, but sets it to an empty/blank value instead.
To remove an env,
VARshall be used (without the assigment operator.)SSL_CERT_FILE,CURL_HOME,HOME,XDG_CONFIG_HOME, were addedbefore the change above. Make tests unset these envs again, as their
commit messages suggest, instead of blanking them. It does not change
the outcome of the tests.
Ref: 764e4f0 #8213
Ref: e992770 #6600
Folllow-up to 7cf8414 #12862
Cherry-picked from #17988