lib1560: fix memory leak when run without UTF-8 support#17998
Closed
vszakats wants to merge 1 commit intocurl:masterfrom
Closed
lib1560: fix memory leak when run without UTF-8 support#17998vszakats wants to merge 1 commit intocurl:masterfrom
vszakats wants to merge 1 commit intocurl:masterfrom
Conversation
``` test 1560...[URL API] valgrind ERROR ==13362== 104 bytes in 1 blocks are definitely lost in loss record 1 of 1 ==13362== at 0x484D953: calloc (in /usr/libexec/valgrind/vgpreload_memcheck-amd64-linux.so) ==13362== by 0x48E1302: curl_dbg_calloc (in /home/runner/work/curl/curl/bld/lib/libcurl.so.4.8.0) ==13362== by 0x4931D12: curl_url (in /home/runner/work/curl/curl/bld/lib/libcurl.so.4.8.0) ==13362== by 0x14F658: get_parts (in /home/runner/work/curl/curl/bld/tests/libtest/libtests) ==13362== by 0x150AC6: test_lib1560 (in /home/runner/work/curl/curl/bld/tests/libtest/libtests) ==13362== by 0x17F5D5: main (in /home/runner/work/curl/curl/bld/tests/libtest/libtests) ``` Ref: https://github.com/curl/curl/actions/runs/16446352985/job/46479298080?pr=17988#step:41:3007 Follow-up to 7d1ca2e curl#17933
vszakats
force-pushed
the
lib1560-fix-leak
branch
from
f2c5bd1 to
ee5315d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The issue is missed in CI, because valgrind jobs all run with UTF-8
support.
Fixing:
Ref: https://github.com/curl/curl/actions/runs/16446352985/job/46479298080?pr=17988#step:41:3007
Follow-up to 7d1ca2e #17933
w/o ws https://github.com/curl/curl/pull/17998/files?w=1