Don't insert a node into the splay tree twice#18005
Closed
dvdzhuang wants to merge 1 commit intocurl:masterfrom
Closed
Don't insert a node into the splay tree twice#18005dvdzhuang wants to merge 1 commit intocurl:masterfrom
dvdzhuang wants to merge 1 commit intocurl:masterfrom
Conversation
bagder
approved these changes
Jul 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Specific to multiplexing with PIPEWAIT enabled - when a pending handle times out before its corresponding connecting handle, its timenode is erroneously inserted twice into the multi handle splay tree. This can lead to infinite loops or invalid accesses.
Here is a simple program that consistently reproduces the issue for me:
To verify the duplicate insert, I was running with these changes locally: master...dvdzhuang:curl:checksplaytree
I was thinking that it might be good to have some strong guarantee that the node passed to Curl_splayinsert has a zeroed out time key but would like to know your thoughts. Thanks!