ci: Update dependency ngtcp2/ngtcp2 to v1.14.0#18022
Closed
renovate[bot] wants to merge 1 commit intomasterfrom
Closed
ci: Update dependency ngtcp2/ngtcp2 to v1.14.0#18022renovate[bot] wants to merge 1 commit intomasterfrom
renovate[bot] wants to merge 1 commit intomasterfrom
Conversation
Member
|
Failure is triggered by this ngtcp2 commit: All pkg-config dependencies, including https://github.com/curl/curl/actions/runs/16532686608/job/46761392076?pr=18028#step:14:605 So far the only solution was to delete the Doing tests over at #18028. |
vszakats
added a commit
to vszakats/curl
that referenced
this pull request
Mar 13, 2026
This was referenced Mar 13, 2026
vszakats
added a commit
to vszakats/curl
that referenced
this pull request
Mar 16, 2026
To aid debugging cases when dependency detection acts unexpectedly. Sprung from spending days trying to figure out behavior of ngtcp2 crypto modules and their dependencies. You can enable via by setting env `CURL_TRACE_PKG_CONFIG` to a non-empty value. When enabled detection details are logged for both successful and unsuccessful detections. Logging of unsuccessful ones is automatically enabled when `CURL_CI` env is set, which is the case for all CI jobs. It works by asking for `--debug` output and grepping for lines that seem useful for this specific purpose. Output is different for classic pkg-config and pkgconf, and may depending on tool version. If there is a built-in feature like this in classic pkg-config or pkgconf, I could not find it. Also: - GHA/http3-linux: set `CURL_TRACE_PKG_CONFIG` to log detection details. H3 builds are a recurring hot-spot for hard-to-debug issues. Ref: curl#20920 Follow-up to 3c64ffa curl#18415 curl#18188 Follow-up to 9950066 curl#18028 curl#18022 Cherry-picked from curl#20926 Closes curl#20926
vszakats
added a commit
that referenced
this pull request
Mar 16, 2026
To aid debugging cases when dependency detection acts unexpectedly. Sprung from spending days trying to figure out behavior of ngtcp2 crypto modules and their dependencies. You can enable by setting env `CURL_TRACE_PKG_CONFIG` to a non-empty value. When enabled, details are logged for both successful and unsuccessful detections. Logging of unsuccessful ones is automatically enabled when `CURL_CI` env is set, which is the case for all CI jobs. It works by asking for `--debug` output and grepping for lines that seem useful for this purpose. Output is different for classic pkg-config and pkgconf, and may depending on tool version. Also append `--print-errors` output if any. Examples (with pkgconf): Fail, before: ``` checking for libngtcp2_crypto_boringssl options with pkg-config... no configure: error: --with-ngtcp2 was specified but could not find ngtcp2_crypto_boringssl pkg-config file. ``` Fail, after: ``` checking for libngtcp2_crypto_boringssl options with pkg-config... no configure: pkg-config --exists libngtcp2_crypto_boringssl trace: ---- begin trying path: /home/runner/nghttp3/build/lib/pkgconfig for libngtcp2_crypto_boringssl trying path: /home/runner/ngtcp2-boringssl/build/lib/pkgconfig for libngtcp2_crypto_boringssl trying path: /home/runner/nghttp3/build/lib/pkgconfig for libngtcp2 trying path: /home/runner/ngtcp2-boringssl/build/lib/pkgconfig for libngtcp2 trying path: /home/runner/nghttp3/build/lib/pkgconfig for openssl trying path: /home/runner/ngtcp2-boringssl/build/lib/pkgconfig for openssl trying path: /home/runner/nghttp2/build/lib/pkgconfig for openssl ==== error: Package openssl was not found in the pkg-config search path. Perhaps you should add the directory containing `openssl.pc' to the PKG_CONFIG_PATH environment variable Package 'openssl', required by 'libngtcp2_crypto_boringssl', not found ---- end configure: error: --with-ngtcp2 was specified but could not find ngtcp2_crypto_boringssl pkg-config file. ``` Success, after: ``` checking for libngtcp2_crypto_boringssl options with pkg-config... found configure: pkg-config --exists libngtcp2_crypto_boringssl trace: ---- begin trying path: /home/runner/awslc/build/lib/pkgconfig for libngtcp2_crypto_boringssl trying path: /home/runner/nghttp3/build/lib/pkgconfig for libngtcp2_crypto_boringssl trying path: /home/runner/nghttp2/build/lib/pkgconfig for libngtcp2_crypto_boringssl trying path: /home/runner/ngtcp2/build/lib/pkgconfig for libngtcp2_crypto_boringssl trying path: /home/runner/awslc/build/lib/pkgconfig for libngtcp2 trying path: /home/runner/nghttp3/build/lib/pkgconfig for libngtcp2 trying path: /home/runner/nghttp2/build/lib/pkgconfig for libngtcp2 trying path: /home/runner/ngtcp2/build/lib/pkgconfig for libngtcp2 trying path: /home/runner/awslc/build/lib/pkgconfig for openssl trying path: /home/runner/awslc/build/lib/pkgconfig for libssl trying path: /home/runner/awslc/build/lib/pkgconfig for libcrypto ---- end ``` More examples: #20926 (comment) If there is an externally enablable, built-in feature like this in classic pkg-config or pkgconf, I could not find it. Also: - GHA/http3-linux: set `CURL_TRACE_PKG_CONFIG` to log detection details. H3 builds are prone to hard-to-debug dependency issues. Ref: #20920 Follow-up to 3c64ffa #18415 #18188 Follow-up to 9950066 #18028 #18022 Cherry-picked from #20926 Closes #20931
vszakats
added a commit
to vszakats/curl
that referenced
this pull request
Mar 16, 2026
vszakats
added a commit
to vszakats/curl
that referenced
this pull request
Mar 16, 2026
vszakats
added a commit
to vszakats/curl
that referenced
this pull request
Mar 16, 2026
3c64ffa curl#18415 curl#18188 9950066 curl#18028 curl#18022 test both ngtcp2 config methods boringssl fixup leave libressl as-is in this PR (unrelated and tackled in another one) http3-linux.yml test all combinations
vszakats
added a commit
that referenced
this pull request
Mar 17, 2026
Configure LibreSSL autotools job with `--with-ngtcp=<path>` instead of adding ngtcp2 to `PKG_CONFIG_PATH`. To test this way of configuration in CI and test for the regression reported in #20889. Turns out this way of configuration isn't affected by the detection issue in this particular case. It also works for other backends except for these two, subject to separate fixes: - BoringSSL fix: ngtcp2/ngtcp2#2070 - GnuTLS fix and BoringSSL workaround: #20920 Follow-up to 666db80 #20891 Follow-up to 8db0e28 #18189 Follow-up to 9950066 #18028 #18022 Closes #20926
vszakats
added a commit
to vszakats/curl
that referenced
this pull request
Mar 17, 2026
3c64ffa curl#18415 curl#18188 9950066 curl#18028 curl#18022 test both ngtcp2 config methods boringssl fixup leave libressl as-is in this PR (unrelated and tackled in another one) http3-linux.yml test all combinations
vszakats
added a commit
to vszakats/curl
that referenced
this pull request
Mar 17, 2026
3c64ffa curl#18415 curl#18188 9950066 curl#18028 curl#18022 test both ngtcp2 config methods boringssl fixup leave libressl as-is in this PR (unrelated and tackled in another one) http3-linux.yml test all combinations
vszakats
added a commit
that referenced
this pull request
Mar 17, 2026
ngtcp2 1.14.0 added module dependencies to `ngtcp2_crypto_*.pc` files.
This broke certain build cases in curl, because configure was is
querying pkg-config modules by setting `PKG_CONFIG_LIBDIR` to the
directory specified via `--with-*=` options, including `--with-ngtcp2=`.
Setting `PKG_CONFIG_LIBDIR` tells pkg-config (and pkgconf) to ignore
system locations. This caused that `ngtcp2_crypto_gnutls.pc` could no
longer find its indirect dependencies, if those were present at system
locations (where they typically are). Another fallout was BoringSSL,
because it does not provide `openssl.pc` on its own, and successful
detection relied on finding a non-BoringSSL copy, typically at a system
location (also fixed in ngtcp2 main branch).
Fix `ngtcp2_crypto_*` detections to not touch `PKG_CONFIG_LIBDIR` and
instead prepend `<path>` set via `--with-ngtcp2=` to `PKG_CONFIG_PATH`.
This ensures to pick up any dependent modules from system locations.
Note the side-effect is that potentially undesired modules may be
detected this way from system locations, i.e. it makes this particular
detection less "hermetic" than the rest used in curl configure.
(Configurations using a bare `--with-ngtcp2` with no path were not
affected, and served as a workaround before this patch. It remains a
valid way of configuration after.)
Both `pkgconf` and `pkg-config` use this logic to calculate their search
directory list:
```pseudo
search = {}
if PKG_CONFIG_PATH is set
search += PKG_CONFIG_PATH
endif
if PKG_CONFIG_LIBDIR is set (even if empty)
search += PKG_CONFIG_LIBDIR
else
search += built-in-pkg-config-dirs
endif
```
Refs:
https://github.com/curl/curl/pull/18028/commits (earlier attempt. Failed due to using `PKG_CONFIG_DIR` instead of the correct `PKG_CONFIG_PATH`)
c0874ce
https://man.archlinux.org/man/pkgconf.1.en
https://manpages.debian.org/unstable/pkgconf/pkgconf.1.en.html
https://manpages.debian.org/unstable/pkg-config/pkg-config.1.en.html
ngtcp2/ngtcp2@10e27fd
Bug: #18022 (comment)
Bug: ngtcp2/ngtcp2#1689 (comment)
Follow-up to 04d90b5 #20931
Follow-up to 3c64ffa #18415 #18188
Follow-up to 9950066 #18028 #18022
Closes #20920
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains the following updates:
1.13.0->1.14.0Release Notes
ngtcp2/ngtcp2 (ngtcp2/ngtcp2)
v1.14.0: ngtcp2 v1.14.0Compare Source
What's Changed
New Contributors
Full Changelog: ngtcp2/ngtcp2@v1.13.0...v1.14.0
Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.