inet_pton, inet_ntop: drop declarations when unused#18043
Closed
vszakats wants to merge 1 commit intocurl:masterfrom
Closed
inet_pton, inet_ntop: drop declarations when unused#18043vszakats wants to merge 1 commit intocurl:masterfrom
vszakats wants to merge 1 commit intocurl:masterfrom
Conversation
Seen in the VisualStudioSolution (VS2013) job on AppVeyor: ``` 3>..\..\..\..\lib\hostip.c(148): warning C4090: 'function' : different 'const' qualifiers [C:\projects\curl\projects\Windows\VC12\lib\libcurl.vcxproj] 3>..\..\..\..\lib\hostip.c(155): warning C4090: 'function' : different 'const' qualifiers [C:\projects\curl\projects\Windows\VC12\lib\libcurl.vcxproj] ``` Ref: https://ci.appveyor.com/project/curlorg/curl/builds/52470650/job/gslnjrdxnd8b9mtv#L180
vszakats
changed the title
vszakats
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Do not declare local inet_pton/inet_ntop implementations when they are
not used. In this case the same symbol is defined as a macro and mapped
to the system implementation.
Syncing this with their definitions.