config-win32.h: do not use winsock2 inet_ntop()/inet_pton()#18045
Closed
vszakats wants to merge 4 commits intocurl:masterfrom
Closed
config-win32.h: do not use winsock2 inet_ntop()/inet_pton()#18045vszakats wants to merge 4 commits intocurl:masterfrom
inet_ntop()/inet_pton()#18045vszakats wants to merge 4 commits intocurl:masterfrom
Conversation
Syncing winbuild and VS Project File builds with this fix applied to the standard builds earlier. Also fixes these warnings seen in the VisualStudioSolution (VS2013) job on AppVeyor CI: ``` lib\hostip.c(148): warning C4090: 'function' : different 'const' qualifiers lib\hostip.c(155): warning C4090: 'function' : different 'const' qualifiers ``` Ref: https://ci.appveyor.com/project/curlorg/curl/builds/52470650/job/gslnjrdxnd8b9mtv#L180 Follow-up to 8537a5b curl#16577
vszakats
changed the title
inet_pton, inet_ntopinet_ntop()/inet_pton()
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Syncing winbuild and VS Project File builds with the same fix applied
to cmake and autotools builds earlier.
Also fixes these warnings seen in the VisualStudioSolution (VS2013) job
on AppVeyor CI:
Ref: https://ci.appveyor.com/project/curlorg/curl/builds/52470650/job/gslnjrdxnd8b9mtv#L180
Went unnoticed because warnings are not promoted to error in these builds.
winbuild CI jobs did not hit this warning for some reason.
Follow-up to 8537a5b #16577