Skip to content

delta: fix warnings, fix for non-GNU date tool#18061

Closed
vszakats wants to merge 3 commits intocurl:masterfrom
vszakats:fixdelta
Closed

delta: fix warnings, fix for non-GNU date tool#18061
vszakats wants to merge 3 commits intocurl:masterfrom
vszakats:fixdelta

Conversation

@vszakats
Copy link
Member

@vszakats vszakats commented Jul 28, 2025

It makes the script run on BSD-like envs.

Follow-up to f63bdea #18058
Follow-up to 2ec5455 #17877

@vszakats vszakats changed the title delta: fix warnings, fix for non-GNU date tool delta: fix warnings, fix for non-GNU date tool Jul 28, 2025
@vszakats vszakats closed this in b1df1d3 Jul 28, 2025
vszakats added a commit that referenced this pull request Jul 28, 2025
Fixing on macOS, and possibly other BSDs:
```
sed: 83: ./docs/THANKS-filter: RE error: illegal byte sequence
```
Where line 83 contains `\xED`.

Switch to raw encoding to avoid `sed` evaluating the stream of bytes.

Ref: #18061

Closes #18062
@vszakats vszakats deleted the fixdelta branch July 28, 2025 15:32
@bagder
Copy link
Member

bagder commented Jul 29, 2025

This commit broke several of the counters

@vszakats
Copy link
Member Author

vszakats commented Jul 29, 2025

Sorry! I think it's the wrong scope of mode. Fix coming up → #18074.

@vszakats
Copy link
Member Author

Does this fix it?:

--- a/scripts/delta
+++ b/scripts/delta
@@ -119,9 +119,9 @@ if($diffstat =~ /^ *(\d+) files changed, (\d+) insertions\(\+\), (\d+)/) {
 my $numchanges = 0;
 my $numbugfixes = 0;
 my $numcontributors = 0;
+my $mode = 0;
 open(F, "<RELEASE-NOTES");
 while(<F>) {
-    my $mode=0;
     if($_ =~ /following changes:/) {
         $mode=1;
     }

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

2 participants

Comments