Closed
Conversation
vszakats
pushed a commit
to vszakats/curl
that referenced
this pull request
Jul 28, 2025
Add tests of CURLINFO_TLS_SSL_PTR and its returned value in test client 'hx-download'. Use obtained pointer to look up the negotiated TLS version. Update manpage of CURLINFO_TLS_SSL_PTR to also describe the behaviour of wolfSSL similar to OpenSSL. Fix the wolfSSl implementation for TCP to behave like that. Update the QUIC queries. Fix rustls `get_internals()` to return the rustls_connection* and not the address of the pointer. Closes curl#18066
6 tasks
vszakats
added a commit
that referenced
this pull request
Jul 29, 2025
Member
Add tests of CURLINFO_TLS_SSL_PTR and its returned value in test client 'hx-download'. Use obtained pointer to look up the negotiated TLS version. Update manpage of CURLINFO_TLS_SSL_PTR to also describe the behaviour of wolfSSL similar to OpenSSL. Fix the wolfSSl implementation for TCP to behave like that. Update the QUIC queries. Fix rustls `get_internals()` to return the rustls_connection* and not the address of the pointer.
VS2022 compiler warning: ``` tests\client\hx_download.c(199,7): warning C4065: switch statement contains 'default' but no 'case' labels ``` https://ci.appveyor.com/project/curlorg/curl/builds/52476876/job/axqek5whkn3q69s7#L257
AM Alpine MUSL https-rr c-ares:
```
../../../lib/memdebug.h:40:59: error: expected declaration specifiers or '...' before numeric constant
40 | #define calloc(nbelem,size) curl_dbg_calloc(nbelem, size, __LINE__, __FILE__)
| ^~~~~~~~
../../../lib/memdebug.h:40:69: error: expected declaration specifiers or '...' before string constant
40 | #define calloc(nbelem,size) curl_dbg_calloc(nbelem, size, __LINE__, __FILE__)
| ^~~~~~~~
../../../lib/memdebug.h:44:38: error: expected declaration specifiers or '...' before numeric constant
44 | #define free(ptr) curl_dbg_free(ptr, __LINE__, __FILE__)
| ^~~~~~~~
../../../lib/memdebug.h:44:48: error: expected declaration specifiers or '...' before string constant
44 | #define free(ptr) curl_dbg_free(ptr, __LINE__, __FILE__)
| ^~~~~~~~
```
https://github.com/curl/curl/actions/runs/16610859929/job/46993519059?pr=18066#step:38:59
Member
|
After rebasing to the clients+libtests merge in master, this PR I merged a fix for |
3 tasks
Contributor
Author
|
Thanks @vszakats for fixing this so quickly! |
bagder
approved these changes
Aug 1, 2025
vszakats
added a commit
that referenced
this pull request
Feb 11, 2026
Fixes: ``` $ wine libtests.exe cli_hx_download https://curl.se/ [...] Assertion failed: t->checked_ssl, file .../curl/tests/libtest/cli_hx_download.c, line 563 ``` into: ``` [t-0] info Schannel TLS version 0x00000800 ``` Refs: https://learn.microsoft.com/windows/win32/secauthn/querycontextattributes--general https://learn.microsoft.com/windows/win32/api/schannel/ns-schannel-secpkgcontext_connectioninfo Ref: c220674 #20564 Follow-up to ba9ddb9 #18066 Closes #20556
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add tests of CURLINFO_TLS_SSL_PTR and its returned value in test client 'hx-download'. Use obtained pointer to look up the negotiated TLS version.
Update manpage of CURLINFO_TLS_SSL_PTR to also describe the behaviour of wolfSSL similar to OpenSSL. Fix the wolfSSl implementation for TCP to behave like that. Update the QUIC queries.
Fix rustls
get_internals()to return the rustls_connection* and not the address of the pointer.