Skip to content

schannel: drop fallbacks for unused BCRYPT_* macros#18091

Closed
vszakats wants to merge 2 commits intocurl:masterfrom
vszakats:wbcrypt
Closed

schannel: drop fallbacks for unused BCRYPT_* macros#18091
vszakats wants to merge 2 commits intocurl:masterfrom
vszakats:wbcrypt

Conversation

@vszakats
Copy link
Member

@vszakats vszakats commented Jul 30, 2025

In case they are used again in the future, the fallbacks are not
necessary for the supported mingw-w64 (v3+) and MSVC versions.

Follow-up to 6238888 #15621

@vszakats vszakats added TLS Windows Windows-specific tidy-up labels Jul 30, 2025
@vszakats vszakats changed the title schannel: drop fallbacks for unused macros schannel: drop fallbacks for unused BCRYPT_* macros Jul 30, 2025
@vszakats vszakats closed this in dfe3844 Jul 30, 2025
@vszakats vszakats deleted the wbcrypt branch July 30, 2025 10:25
@vszakats
Copy link
Member Author

vszakats commented Jul 30, 2025

Hm, the commit message may be incorrect. VS2008 came with MS SDK 6.0a,
which is what we support now, and VS2010 came with MS SDK 7.0a, which is
soon to be the minimum. I need to get a copy of these old versions and recalculate.

Anyway these macros aren't used in the source, so the commit itself is fine.

@jay
Copy link
Member

jay commented Jul 30, 2025

Here's the hashes from the official VS2010 ISOs (2010 original + SP1 ugprade) that I downloaded from MS technet.

$ sha256sum *.iso
fce24f0e3f95fdeb54b806be3266f3b61a1e6b5b78c7e6c13c36fc1a6f5ba0ad *VS2010SP1dvd1.iso
bdfba5df0bd72cffdb398fe885d9e36d052617647c0ae4fd0579a8fc785c95ba *en_Visual_Studio2010_Professional_x86_x16-81637.iso

Note if you are building a dev VM with versions older than that like 2008 I recall Microsoft used to warn to install in chronological order. For example 2005, 2005 service pack(s), 2008, 2008 service pack(s), 2010, 2010 service pack

@vszakats
Copy link
Member Author

Got them, thanks a lot!

@vszakats
Copy link
Member Author

These macros require MS SDK v7.0A (VS2010) or newer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

2 participants

Comments