schannel: drop fallbacks for unused BCRYPT_* macros#18091
Closed
vszakats wants to merge 2 commits intocurl:masterfrom
Closed
schannel: drop fallbacks for unused BCRYPT_* macros#18091vszakats wants to merge 2 commits intocurl:masterfrom
BCRYPT_* macros#18091vszakats wants to merge 2 commits intocurl:masterfrom
Conversation
supported by mingw-w64 v2+ and all VS Also not used anymore by curl code after 6238888
BCRYPT_* macros
Member
Author
|
Hm, the commit message may be incorrect. VS2008 came with MS SDK 6.0a, Anyway these macros aren't used in the source, so the commit itself is fine. |
Member
|
Here's the hashes from the official VS2010 ISOs (2010 original + SP1 ugprade) that I downloaded from MS technet. Note if you are building a dev VM with versions older than that like 2008 I recall Microsoft used to warn to install in chronological order. For example 2005, 2005 service pack(s), 2008, 2008 service pack(s), 2010, 2010 service pack |
Member
Author
|
Got them, thanks a lot! |
Member
Author
|
These macros require MS SDK v7.0A (VS2010) or newer. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In case they are used again in the future, the fallbacks are not
necessary for the supported mingw-w64 (v3+) and MSVC versions.
Follow-up to 6238888 #15621