schannel: drop fallbacks for 4 macros#18093
Closed
vszakats wants to merge 4 commits intocurl:masterfrom
Closed
Conversation
4 tasks
supported by all mingw-w64 and msvc versions
This reverts commit 8022649.
Member
Author
|
This may have been premature and/or the commit message inaccurate. edit: we do test with VS2010 in CI, so that should be fine. |
Member
Author
|
Passed VS2008 in CI: https://ci.appveyor.com/project/curlorg/curl/builds/52486233/job/ptntb3r9f5n5n4yy |
Member
Author
|
Confirmed that all 4 macros are present in MS SDK 6.0A (VS2008) and later. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
They are defined by all mingw-w64 versions and all supported MSVC
versions (SDK 7.1A+).
Also by OpenWatcom 2:
https://github.com/open-watcom/open-watcom-v2/blob/ce6c37eb29f3fda95f9c4e8e37dee866b8c4e496/bld/w32api/include/wincrypt.mh
These aren't defined by mingw32ce. And likely defined by MS WinCE SDK,
but curl code doesn't use them in WinCE builds.