Skip to content

schannel: drop fallbacks for 4 macros#18093

Closed
vszakats wants to merge 4 commits intocurl:masterfrom
vszakats:wmacro
Closed

schannel: drop fallbacks for 4 macros#18093
vszakats wants to merge 4 commits intocurl:masterfrom
vszakats:wmacro

Conversation

@vszakats
Copy link
Member

@vszakats vszakats commented Jul 30, 2025

They are defined by all mingw-w64 versions and all supported MSVC
versions (SDK 7.1A+).

Also by OpenWatcom 2:
https://github.com/open-watcom/open-watcom-v2/blob/ce6c37eb29f3fda95f9c4e8e37dee866b8c4e496/bld/w32api/include/wincrypt.mh

These aren't defined by mingw32ce. And likely defined by MS WinCE SDK,
but curl code doesn't use them in WinCE builds.

@vszakats vszakats added TLS Windows Windows-specific tidy-up labels Jul 30, 2025
@vszakats vszakats changed the title schannel: drop fallbacks for 4 macros schannel: limit 4 fallback macros to mingw32ce Jul 30, 2025
@vszakats vszakats changed the title schannel: limit 4 fallback macros to mingw32ce schannel: drop 4 fallback macros Jul 30, 2025
@vszakats vszakats changed the title schannel: drop 4 fallback macros schannel: drop fallback for 4 macros Jul 30, 2025
@vszakats vszakats changed the title schannel: drop fallback for 4 macros schannel: drop fallbacks for 4 macros Jul 30, 2025
@vszakats vszakats closed this in e32a6dc Jul 30, 2025
@vszakats vszakats deleted the wmacro branch July 30, 2025 10:25
@vszakats
Copy link
Member Author

vszakats commented Jul 30, 2025

This may have been premature and/or the commit message inaccurate.
VS2008 came with MS SDK 6.0a, which is what we support now, and
VS2010 came with MS SDK 7.0a, which is soon to be the minimum.
I need to get a copy of these old versions and recalculate.

edit: we do test with VS2010 in CI, so that should be fine.

@vszakats
Copy link
Member Author

@vszakats
Copy link
Member Author

Confirmed that all 4 macros are present in MS SDK 6.0A (VS2008) and later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

1 participant

Comments