tests: fix prechecks to call the bundle libtest tool#18099
Closed
vszakats wants to merge 5 commits intocurl:masterfrom
Closed
tests: fix prechecks to call the bundle libtest tool#18099vszakats wants to merge 5 commits intocurl:masterfrom
vszakats wants to merge 5 commits intocurl:masterfrom
Conversation
Fixing, e.g.: ``` test 1517 SKIPPED: precheck command error ``` https://github.com/curl/curl/actions/runs/16611990422/job/46996698437?pr=18039#step:13:4832
This comment was marked as outdated.
This comment was marked as outdated.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some tests make a hard-coded call to the libtest binary in the precheck
step. With bundle builds the binary changed name and calling convention.
Before this patch these tests failed the pre-check and did not run for
the 5 affected tests: 518, 537, 678, 1517, 1960
Fixing, e.g.:
https://github.com/curl/curl/actions/runs/16611990422/job/46996698437?pr=18039#step:13:4832
It also fixes builds with a custom
CURL_DIRSUFFIXset.Follow-up to 2c27a67 #17590
Follow-up to 71cf0d1 #14772