bufq: add integer overflow checks before chunk allocations#18112
Closed
coleleavitt wants to merge 3 commits intocurl:masterfrom
Closed
bufq: add integer overflow checks before chunk allocations#18112coleleavitt wants to merge 3 commits intocurl:masterfrom
coleleavitt wants to merge 3 commits intocurl:masterfrom
Conversation
bagder
approved these changes
Jul 31, 2025
Member
bagder
left a comment
There was a problem hiding this comment.
SIZE_MAX is a very large limit but I suppose the check is still sensible!
icing
approved these changes
Jul 31, 2025
Member
|
This will be easier if you stop merging in unrelated things. |
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add defensive int overflow checking in the buffer queue allocation functions to prevent potential heap buffer overflows if large chunk sizes are ever used.
The calculation
sizeof(*chunk) + q->chunk_sizehas the potential to overflow if chunk_size is near SIZE_MAX which results in a smaller allocation than intended.Through testing this is not an exploitable vulnerability in release.